Skip to content

Commit

Permalink
Refactor ReactBridgeStartupData to work with QPL and remove unused fi…
Browse files Browse the repository at this point in the history
…elds

Summary:
This class contains metrics about RN bridge startup that was being sent via FBAnalytics.

This diff refactors out any timespans being collected into a separate method. This refactor is NOT ENOUGH to format the data into a format QPL accepts. I still need to refactor these timespans into _start and _end points for QPL points to work correctly. This diff is a starting point.

Reviewed By: ejanzer

Differential Revision: D10466982

fbshipit-source-id: 4bc1159c4e53328f2252a8c606c8d6ff8d657489
  • Loading branch information
Peter Argany authored and facebook-github-bot committed Oct 22, 2018
1 parent a07de97 commit 3e0bc63
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions React/Base/RCTPerformanceLogger.h
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,8 @@ typedef NS_ENUM(NSUInteger, RCTPLTag) {
RCTPLNativeModuleInit,
RCTPLNativeModuleMainThread,
RCTPLNativeModulePrepareConfig,
RCTPLNativeModuleInjectConfig,
RCTPLNativeModuleMainThreadUsesCount,
RCTPLJSCWrapperOpenLibrary,
RCTPLJSCExecutorSetup,
RCTPLBridgeStartup,
RCTPLTTI,
RCTPLBundleSize,
Expand Down

0 comments on commit 3e0bc63

Please sign in to comment.