Skip to content

Commit

Permalink
fsldma: fix controller lockups
Browse files Browse the repository at this point in the history
Enabling poisoning in the dmapool API quickly showed that the DMA
controller was fetching descriptors that should not have been in use.
This has caused intermittent controller lockups during testing.

I have been unable to figure out the exact set of conditions which cause
this to happen. However, I believe it is related to the driver using the
hardware registers to track whether the controller is busy or not. The
code can incorrectly decide that the hardware is idle due to lag between
register writes and the hardware actually becoming busy.

To fix this, the driver has been reworked to explicitly track the state
of the hardware, rather than try to guess what it is doing based on the
register values.

This has passed dmatest with 10 threads per channel, 100000 iterations
per thread several times without error. Previously, this would fail
within a few seconds.

Signed-off-by: Ira W. Snyder <[email protected]>
Signed-off-by: Dan Williams <[email protected]>
  • Loading branch information
Ira Snyder authored and djbw committed Mar 12, 2011
1 parent 31f4306 commit f04cd40
Show file tree
Hide file tree
Showing 2 changed files with 99 additions and 122 deletions.
Loading

0 comments on commit f04cd40

Please sign in to comment.