Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConstantParameter now accepts an Expression #417

Merged
merged 3 commits into from
Nov 20, 2018

Conversation

lumip
Copy link
Contributor

@lumip lumip commented Nov 19, 2018

Can now (legally) pass in an Expression object or a string representing an expression without free variables as value of a ConstantParameter.

closes #363

Apparently this was already done (even with expressions with free variables) in some tests in which parameters where never evaluated so no error occured. This has been resolved.

… as value (given as `Expression` or string)
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1602

  • 7 of 10 (70.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.1%) to 93.467%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qupulse/pulses/parameters.py 7 10 70.0%
Files with Coverage Reduction New Missed Lines %
qupulse/utils/types.py 1 98.39%
qupulse/pulses/mapping_pulse_template.py 1 96.6%
Totals Coverage Status
Change from base Build 1589: -0.1%
Covered Lines: 4623
Relevant Lines: 4881

💛 - Coveralls

4 similar comments
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1602

  • 7 of 10 (70.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.1%) to 93.467%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qupulse/pulses/parameters.py 7 10 70.0%
Files with Coverage Reduction New Missed Lines %
qupulse/utils/types.py 1 98.39%
qupulse/pulses/mapping_pulse_template.py 1 96.6%
Totals Coverage Status
Change from base Build 1589: -0.1%
Covered Lines: 4623
Relevant Lines: 4881

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1602

  • 7 of 10 (70.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.1%) to 93.467%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qupulse/pulses/parameters.py 7 10 70.0%
Files with Coverage Reduction New Missed Lines %
qupulse/utils/types.py 1 98.39%
qupulse/pulses/mapping_pulse_template.py 1 96.6%
Totals Coverage Status
Change from base Build 1589: -0.1%
Covered Lines: 4623
Relevant Lines: 4881

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1602

  • 7 of 10 (70.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.1%) to 93.467%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qupulse/pulses/parameters.py 7 10 70.0%
Files with Coverage Reduction New Missed Lines %
qupulse/utils/types.py 1 98.39%
qupulse/pulses/mapping_pulse_template.py 1 96.6%
Totals Coverage Status
Change from base Build 1589: -0.1%
Covered Lines: 4623
Relevant Lines: 4881

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1602

  • 7 of 10 (70.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.1%) to 93.467%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qupulse/pulses/parameters.py 7 10 70.0%
Files with Coverage Reduction New Missed Lines %
qupulse/utils/types.py 1 98.39%
qupulse/pulses/mapping_pulse_template.py 1 96.6%
Totals Coverage Status
Change from base Build 1589: -0.1%
Covered Lines: 4623
Relevant Lines: 4881

💛 - Coveralls

@coveralls
Copy link

coveralls commented Nov 19, 2018

Pull Request Test Coverage Report for Build 1606

  • 10 of 10 (100.0%) changed or added relevant lines in 1 file are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.04%) to 93.525%

Files with Coverage Reduction New Missed Lines %
qupulse/pulses/mapping_pulse_template.py 1 96.6%
qupulse/utils/types.py 5 95.16%
Totals Coverage Status
Change from base Build 1589: -0.04%
Covered Lines: 4626
Relevant Lines: 4880

💛 - Coveralls

@shumpohl shumpohl merged commit 0ae5235 into master Nov 20, 2018
@lumip lumip deleted the issues/363_constant_param_sympy_expr branch December 4, 2018 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow ConstantParameter to accept variable-free sympy expressions.
3 participants