Alternative/Revised Plotting Classes #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…equencingHardwareInterface subtype (no Sequener subclass is needed).
pbethke
added a commit
that referenced
this pull request
Sep 11, 2015
Alternative/Revised Plotting Classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sequencer was intended to be used with specialized subtypes of SequencingHardwareInterface to achieve translations to different target hardware (or software) data structures without changing Sequencer itself.
Following this idea, I've changed the Plotting.py such that all meaningful calculations are done in a SequencingHardwareInterface subtype called Plotter which works with the default Sequencer and removed the classes PlottingSequencer and PlottingDummySequencingHardware (the latter of which did not do anything meaningful).