-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue702: Add example 03SnakeChargeScan #732
Conversation
.gitignore
Outdated
@@ -14,3 +14,6 @@ MATLAB/+qc/personalPaths.mat | |||
.idea/ | |||
.mypy_cache/* | |||
tests/hardware/WX2184C.exe | |||
research_tech/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not put personal files here.
.vscode
is fine but the other two aren't. You can either not commit them or insert these lines into .git/info/exclude
Can you rebase on the current master? |
The parameter constraints examples is supposed to start with "01" |
I see, it should be the leftover of an outdated local repo. Should I remove it? Which index can I use for the charge scan example then? |
My idea was to group the examples in The snake case should go to 03 I guess. |
alright. It is now renamed and I will push my local change soon. Let me know if any problems remain. |
Looks good. Can you merge the master and reexecute the parameter contraints example? It looks like the current is based on an old master branch version with issue #707 unfixed (is fixed in current master). |
Rebased in #737 |
Complete the snaked charge scan as an example of:
Task 1: explore functionalities of
qupulse.pulses.plotting.plot
and piecewise the pulse artificially.Task 2: simplify the pulse by decoupling the measurement windows from the piecewise pulse.
Task 3: testing helper functions
with_*
as mentioned in issue 710