Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue702: Add example 03SnakeChargeScan #732

Closed
wants to merge 14 commits into from
Closed

Issue702: Add example 03SnakeChargeScan #732

wants to merge 14 commits into from

Conversation

BrllsRX
Copy link
Collaborator

@BrllsRX BrllsRX commented Dec 19, 2022

Complete the snaked charge scan as an example of:
Task 1: explore functionalities of qupulse.pulses.plotting.plot and piecewise the pulse artificially.
Task 2: simplify the pulse by decoupling the measurement windows from the piecewise pulse.
Task 3: testing helper functions with_* as mentioned in issue 710

@BrllsRX BrllsRX requested a review from terrorfisch December 19, 2022 09:41
.gitignore Outdated
@@ -14,3 +14,6 @@ MATLAB/+qc/personalPaths.mat
.idea/
.mypy_cache/*
tests/hardware/WX2184C.exe
research_tech/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not put personal files here.
.vscode is fine but the other two aren't. You can either not commit them or insert these lines into .git/info/exclude

@terrorfisch
Copy link
Member

Can you rebase on the current master?

@terrorfisch
Copy link
Member

The parameter constraints examples is supposed to start with "01"

@BrllsRX
Copy link
Collaborator Author

BrllsRX commented Dec 19, 2022

I see, it should be the leftover of an outdated local repo. Should I remove it? Which index can I use for the charge scan example then?

@terrorfisch
Copy link
Member

My idea was to group the examples in
00: PulseTemplates
01: Additional functionality
02: reserved for future use
03: Real-world examples

The snake case should go to 03 I guess.

@BrllsRX
Copy link
Collaborator Author

BrllsRX commented Dec 21, 2022

alright. It is now renamed and I will push my local change soon. Let me know if any problems remain.

@BrllsRX BrllsRX changed the title Issue702: Add example 99SnakeChargeScan Issue702: Add example 03SnakeChargeScan Dec 21, 2022
@terrorfisch
Copy link
Member

Looks good. Can you merge the master and reexecute the parameter contraints example? It looks like the current is based on an old master branch version with issue #707 unfixed (is fixed in current master).

@terrorfisch
Copy link
Member

Rebased in #737

@terrorfisch terrorfisch closed this Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants