Skip to content

Commit

Permalink
add "notranslate" tag, handle default locale fallback, fix certificat…
Browse files Browse the repository at this point in the history
…ions id in metadata
  • Loading branch information
AmruthPillai committed Nov 17, 2023
1 parent 33bcadd commit fe9c19f
Show file tree
Hide file tree
Showing 8 changed files with 131 additions and 110 deletions.
3 changes: 2 additions & 1 deletion apps/artboard/index.html
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<!doctype html>
<html lang="en">
<html lang="en-US" translate="no">
<head>
<base href="/" />

Expand All @@ -12,6 +12,7 @@

<!-- Meta -->
<meta charset="utf-8" />
<meta name="googlebot" content="notranslate" />
<meta name="viewport" content="width=device-width, initial-scale=1" />

<!-- Favicon -->
Expand Down
3 changes: 2 additions & 1 deletion apps/client/index.html
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<!doctype html>
<html lang="en">
<html lang="en-US" translate="no">
<head>
<base href="/" />

Expand All @@ -12,6 +12,7 @@

<!-- Meta -->
<meta charset="utf-8" />
<meta name="googlebot" content="notranslate" />
<meta name="viewport" content="width=device-width, initial-scale=1" />

<!-- White Flash Prevention Script -->
Expand Down
2 changes: 1 addition & 1 deletion apps/client/src/pages/auth/register/page.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export const RegisterPage = () => {
username: "",
email: "",
password: "",
locale: "en",
locale: "en-US",
},
});

Expand Down
37 changes: 25 additions & 12 deletions apps/client/src/pages/home/sections/faq/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,7 @@ const Question1 = () => (
I'm Amruth Pillai, just another run-off-the-mill developer working at Elara Digital GmbH in
Berlin, Germany. I'm married to my beautiful and insanely supportive wife who has helped me
in more ways than one in seeing this project to it's fruition. I am originally from
Bengaluru, India where I was a developer at Postman (the API testing tool) for a short
while.
Bengaluru, India where I was a developer at Postman for a short while.
</p>

<p>
Expand All @@ -43,9 +42,9 @@ const Question1 = () => (
<p>
My dream has always been to build something that at least a handful people use on a daily
basis, and I'm extremely proud to say that Reactive Resume, over it's years of development,
has **helped over half a million people build their resume**, and I hope it only increases
from here and reaches more people who are in need of a good resume to kickstart their career
but can't afford to pay for one.
has <strong>helped over half a million people build their resume</strong>, and I hope it
only increases from here and reaches more people who are in need of a good resume to
kickstart their career.
</p>
</AccordionContent>
</AccordionItem>
Expand Down Expand Up @@ -104,10 +103,13 @@ const Question3 = () => (
</AccordionTrigger>
<AccordionContent className="prose max-w-none dark:prose-invert">
<p>
<strong>If you speak a language other than English</strong>, sign up to be a translator on
Crowdin, our translation management service. You can help translate the product to your
language and share it among your community. Even if the language is already translated, it
helps to sign up as you would be notified when there are new phrases to be translated.
<strong>If you speak a language other than English</strong>, sign up to be a translator on{" "}
<a href="https://translate.rxresu.me/" target="_blank" rel="noreferrer">
Crowdin
</a>
, our translation management service. You can help translate the product to your language
and share it among your community. Even if the language is already translated, it helps to
sign up as you would be notified when there are new phrases to be translated.
</p>

<p>
Expand All @@ -119,7 +121,14 @@ const Question3 = () => (
</p>

<p>
<strong>If you found a bug or have an idea for a feature</strong>, raise an issue on GitHub
<strong>If you found a bug or have an idea for a feature</strong>, raise an issue on{" "}
<a
href="https://github.com/AmruthPillai/Reactive-Resume/issues/new/choose"
target="_blank"
rel="noreferrer"
>
GitHub
</a>{" "}
or shoot me a message and let me know what you'd like to see. I can't promise that it'll be
done soon, but juggling work, life and open-source, I'll definitely get to it when I can.
</p>
Expand Down Expand Up @@ -212,7 +221,11 @@ const Question5 = () => (

<p>
The policy behind "bring your own key" (BYOK) is{" "}
<a href="https://community.openai.com/t/openais-bring-your-own-key-policy/14538/46">
<a
href="https://community.openai.com/t/openais-bring-your-own-key-policy/14538/46"
target="_blank"
rel="noreferrer"
>
still being discussed
</a>{" "}
and probably might change over a period of time, but while it's available, I would keep the
Expand All @@ -221,7 +234,7 @@ const Question5 = () => (

<p>
You are free to turn off all AI features (and not be aware of it's existence) simply by not
adding a key in the Settings page and still make use of all of the useful features that
adding a key in the Settings page and still make use of all the useful features that
Reactive Resume has to offer. I would even suggest you to take the extra step of using
ChatGPT to write your content, and simply copy it over to Reactive Resume.
</p>
Expand Down
8 changes: 7 additions & 1 deletion apps/client/src/providers/locale.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import "@/client/libs/dayjs";
import { i18n } from "@lingui/core";
import { detect, fromStorage, fromUrl } from "@lingui/detect-locale";
import { I18nProvider } from "@lingui/react";
import { languages } from "@reactive-resume/utils";
import { useEffect } from "react";

import { defaultLocale, dynamicActivate } from "../libs/lingui";
Expand All @@ -24,7 +25,12 @@ export const LocaleProvider = ({ children }: Props) => {
defaultLocale,
)!;

dynamicActivate(detectedLocale);
// Activate the locale only if it's supported
if (languages.some((lang) => lang.locale === detectedLocale)) {
dynamicActivate(detectedLocale);
} else {
dynamicActivate(defaultLocale);
}
}, [userLocale]);

return <I18nProvider i18n={i18n}>{children}</I18nProvider>;
Expand Down
6 changes: 3 additions & 3 deletions libs/schema/src/metadata/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { z } from "zod";
export const defaultLayout = [
[
["profiles", "summary", "experience", "education", "projects", "volunteer", "references"],
["skills", "interests", "certification", "awards", "publications", "languages"],
["skills", "interests", "certifications", "awards", "publications", "languages"],
],
];

Expand All @@ -26,7 +26,7 @@ export const metadataSchema = z.object({
theme: z.object({
background: z.string().default("#ffffff"),
text: z.string().default("#000000"),
primary: z.string().default("#000000"),
primary: z.string().default("#dc2626"),
}),
typography: z.object({
font: z.object({
Expand Down Expand Up @@ -64,7 +64,7 @@ export const defaultMetadata: Metadata = {
theme: {
background: "#ffffff",
text: "#000000",
primary: "#000000",
primary: "#dc2626",
},
typography: {
font: {
Expand Down
10 changes: 5 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@reactive-resume/source",
"description": "A free and open-source resume builder that simplifies the process of creating, updating, and sharing your resume.",
"version": "4.0.0-alpha.5",
"version": "4.0.0-alpha.6",
"license": "MIT",
"private": true,
"author": {
Expand Down Expand Up @@ -36,7 +36,7 @@
"@lingui/swc-plugin": "^4.0.4",
"@lingui/vite-plugin": "^4.5.0",
"@nestjs/schematics": "^10.0.3",
"@nestjs/testing": "^10.2.8",
"@nestjs/testing": "^10.2.9",
"@nx/cypress": "17.1.2",
"@nx/eslint-plugin": "17.1.2",
"@nx/eslint": "17.1.2",
Expand Down Expand Up @@ -129,12 +129,12 @@
"@lingui/react": "^4.5.0",
"@nestjs-modules/mailer": "^1.9.1",
"@nestjs/axios": "^3.0.1",
"@nestjs/common": "^10.2.8",
"@nestjs/common": "^10.2.9",
"@nestjs/config": "^3.1.1",
"@nestjs/core": "^10.2.8",
"@nestjs/core": "^10.2.9",
"@nestjs/jwt": "^10.2.0",
"@nestjs/passport": "^10.0.2",
"@nestjs/platform-express": "^10.2.8",
"@nestjs/platform-express": "^10.2.9",
"@nestjs/serve-static": "^4.0.0",
"@nestjs/swagger": "^7.1.16",
"@nestjs/terminus": "^10.1.1",
Expand Down
Loading

0 comments on commit fe9c19f

Please sign in to comment.