fix(globalpatches) randomseed throws error when seeded in wrong context

qzg · Sep 13, 2016 · 3144e77 · 3144e77
1 parent a6301dd
commit 3144e77
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/kong/core/globalpatches.lua b/kong/core/globalpatches.lua
@@ -17,18 +17,19 @@ local seed
 -- unique seed for Nginx workers).
 -- luacheck: globals math
 _G.math.randomseed = function()
-  if ngx.get_phase() ~= "init_worker" then
-    ngx.log(ngx.ERR, "math.randomseed() must be called in init_worker")
-  elseif not seed then
+  if not seed then
+    if ngx.get_phase() ~= "init_worker" then
+      error("math.randomseed() must be called in init_worker", 2)
+    end
+
     seed = ngx.time() + ngx.worker.pid()
     ngx.log(ngx.DEBUG, "random seed: ", seed, " for worker n", ngx.worker.id(),
                        " (pid: ", ngx.worker.pid(), ")")
     randomseed(seed)
   else
     ngx.log(ngx.DEBUG, "attempt to seed random number generator, but ",
-                       "already seeded")
+                       "already seeded with ", seed)
   end
 
   return seed
 end
-