Fix crash when using QProperty<T>::setBinding(Functor ...)

We must move the functor properly into the binding object, otherwise we end up with stale pointers as pointed out by ASAN. Change-Id: Icd84f4c113dd48e1e3e2d744abac0902cdf9339e Reviewed-by: Fabian Kosmale <[email protected]>
qzhsjz · Apr 30, 2020 · 7096489 · 7096489
1 parent 0c4bc39
commit 7096489
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 3 deletions.
diff --git a/src/corelib/kernel/qproperty.h b/src/corelib/kernel/qproperty.h
@@ -316,10 +316,11 @@ class QProperty
 
 #ifndef Q_CLANG_QDOC
     template <typename Functor>
-    QPropertyBinding<T> setBinding(Functor f,
-                                   const QPropertyBindingSourceLocation &location = QT_PROPERTY_DEFAULT_BINDING_LOCATION)
+    QPropertyBinding<T> setBinding(Functor &&f,
+                                   const QPropertyBindingSourceLocation &location = QT_PROPERTY_DEFAULT_BINDING_LOCATION,
+                                   std::enable_if_t<std::is_invocable_v<Functor>> * = nullptr)
     {
-        return setBinding(Qt::makePropertyBinding(f, location));
+        return setBinding(Qt::makePropertyBinding(std::forward<Functor>(f), location));
     }
 #else
     template <typename Functor>

diff --git a/tests/auto/corelib/kernel/qproperty/tst_qproperty.cpp b/tests/auto/corelib/kernel/qproperty/tst_qproperty.cpp
@@ -68,6 +68,7 @@ private slots:
     void genericPropertyBinding();
     void genericPropertyBindingBool();
     void staticChangeHandler();
+    void setBindingFunctor();
 };
 
 void tst_QProperty::functorBinding()
@@ -674,6 +675,17 @@ void tst_QProperty::staticChangeHandler()
     QCOMPARE(t.observedValues, values);
 }
 
+void tst_QProperty::setBindingFunctor()
+{
+    QProperty<int> property;
+    QProperty<int> injectedValue(100);
+    // Make sure that this picks the setBinding overload that takes a functor and
+    // moves it correctly.
+    property.setBinding([&injectedValue]() { return injectedValue.value(); });
+    injectedValue = 200;
+    QCOMPARE(property.value(), 200);
+}
+
 QTEST_MAIN(tst_QProperty);
 
 #include "tst_qproperty.moc"