Fail if database is missing (#418)

Co-authored-by: Xianying Tan <[email protected]>
r-dbi · Dec 28, 2020 · 719bc56 · 719bc56
1 parent 5593cdf
commit 719bc56
Showing 1 changed file with 14 additions and 5 deletions.
diff --git a/tests/testthat/helper.R b/tests/testthat/helper.R
@@ -2,10 +2,19 @@ skip_unless_has_test_db <- function(expr) {
   if (!identical(Sys.getenv("NOT_CRAN"), "true")) {
     return(skip("On CRAN"))
   }
-  tryCatch({
-    DBItest:::connect(expr)
+
+  # Failing database connection should fail the test in DBItest backends
+  if (nzchar(Sys.getenv("DBITEST_BACKENDS"))) {
+    con <- DBItest:::connect(expr)
+    DBI::dbDisconnect(con)
     TRUE
-  }, error = function(e) {
-    skip(paste0("Test database not available:\n'", conditionMessage(e), "'"))
-  })
+  } else {
+    tryCatch({
+      con <- DBItest:::connect(expr)
+      DBI::dbDisconnect(con)
+      TRUE
+    }, error = function(e) {
+      skip(paste0("Test database not available:\n'", conditionMessage(e), "'"))
+    })
+  }
 }