Skip to content

Commit

Permalink
Fix minor warning w/Ubuntu18.04 in host test build (esp8266#5829)
Browse files Browse the repository at this point in the history
GCC reports the following warning about ignoring the return value of
write() (to the console/UART in this instance).

common/MockUART.cpp: In function ‘void uart_do_write_char(int, char)’:
common/MockUART.cpp:67:8: warning: ignoring return value of ‘ssize_t write(int, const void*, size_t)’, declared with attribute warn_unused_result [-Wunused-result]
   write(uart_nr + 1, &c, 1);
   ~~~~~^~~~~~~~~~~~~~~~~~~~

Add a simple warning printout to STDERR which may not be the same as the
UART stream and could succeed.
  • Loading branch information
earlephilhower authored and devyte committed Mar 2, 2019
1 parent 418857a commit 82da5c7
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion tests/host/common/MockUART.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,8 @@ static void
uart_do_write_char(const int uart_nr, char c)
{
if (uart_nr >= UART0 && uart_nr <= UART1)
write(uart_nr + 1, &c, 1);
if (1 != write(uart_nr + 1, &c, 1))
fprintf(stderr, "Unable to write character to emulated UART stream: %d\n", c);
}

// write a new byte into the RX FIFO buffer
Expand Down

0 comments on commit 82da5c7

Please sign in to comment.