Reviewing logging/ increasing timeout error in tests / Updating pipeline to 3.13.1 #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielePalaia
force-pushed
the
increase_time_out_in_tests
branch
from
8e5372a to
10986bd
Compare
DanielePalaia
force-pushed
the
increase_time_out_in_tests
branch
from
10986bd to
895181b
Compare
DanielePalaia
changed the title
DanielePalaia
changed the title
DanielePalaia
force-pushed
the
increase_time_out_in_tests
branch
7 times, most recently
from
be817b9 to
903ef34
Compare
DanielePalaia
force-pushed
the
increase_time_out_in_tests
branch
6 times, most recently
from
9c4b075 to
2c28bdd
Compare
DanielePalaia
force-pushed
the
increase_time_out_in_tests
branch
from
2c28bdd to
efbb23d
Compare
Gsantomaggio
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I reviewed exceptions/Logging.
This closes #180
Exception seems behaving correctly doing several tests on the reliable clients (streams that don't exist, connections parameter wrong, some other corner cases situation).
I modified some logs that were set as warning to error.
Also,
It seems like there are some instability on the tests.
These improvements should let the system tests pass without instability