Automated Resyntax fixes #476
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![resyntax-ci[bot]](https://avatars.githubusercontent.com/in/999945?s=60&v=4){kind=small}
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
This `map` operation can be replaced with a `for/list` loop.
This expression can be replaced with a simpler, equivalent `hash-ref!` expression.
This use of `string-append` can be removed by using `string-join`'s keyword arguments.
Using `when` and `unless` is simpler than a conditional with an always-throwing branch.
This quasiquotation is equialent to a simple `list` call.
This `define-syntax` macro can be replaced with a simpler, equivalent `define-syntax-rule` macro.
`cond` with internal definitions is preferred over `if` with `let`, to reduce nesting
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
The `provide/contract` form is a legacy form made obsolete by `contract-out`.
…ellipses` This `->*` contract can be rewritten using `->` with ellipses.
Use `make-temporary-directory` to make directories instead of `make-temporary-file`.
sorawee
reviewed
Jan 15, 2025
| @@ -65,7 +65,9 @@ | |||
| `(" " ,@(decode-content (list location)) ,(if date "," ".")) | |||
| null) | |||
| (if date `(" " ,@(decode-content (list date)) ".") null) | |||
| (if url `(" " ,(link url (tt url))) null) | |||
| (if url (list " " | |||
There was a problem hiding this comment.
@jackfirth I think this occurs because Resyntax invokes range formatting on only the subexpression, so it doesn't format the entire if expression...
(Actually fmt ideally should collapse (list " " (link url (tt url))) into one line, circumventing this issue, but without shadowing, link is a special form that should be formatted vertically, so that's why fmt introduces a newline)
There was a problem hiding this comment.
Yeah, that's definitely the cause. I'm not sure how to fix it from the Resyntax side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resyntax fixed 20 issues in 7 files.
map-to-forlet-to-defineprovide/contract-to-contract-outif-let-to-condquasiquote-to-listmake-temporary-directory-migrationor-hash-ref-set!-to-hash-ref!cond-let-to-cond-definearrow-contract-with-rest-to-arrow-contract-with-ellipsesstring-append-and-string-join-to-string-joindefine-syntax-syntax-rules-to-define-syntax-rulealways-throwing-if-to-when