Merge pull request dj-stripe#447 from jleclanche/issue/446

Make Charge.customer nullable

djstripe/migrations/0027_auto_20170308_0620.py

@@ -0,0 +1,20 @@
+# Generated by Django 1.10.6 on 2017-03-08 07:18
+from __future__ import unicode_literals
+
+from django.db import migrations, models
+import django.db.models.deletion
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('djstripe', '0026_idempotencykey'),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name='charge',
+            name='customer',
+            field=models.ForeignKey(help_text='The customer associated with this charge.', null=True, on_delete=django.db.models.deletion.CASCADE, related_name='charges', to='djstripe.Customer'),
+        ),
+    ]

djstripe/models.py

@@ -65,7 +65,7 @@ class Charge(StripeCharge):
     )
 
     customer = ForeignKey(
-        "Customer", on_delete=models.CASCADE,
+        "Customer", on_delete=models.CASCADE, null=True,
         related_name="charges",
         help_text="The customer associated with this charge."
     )
@@ -123,8 +123,6 @@ def _attach_objects_hook(self, cls, data):
         customer = cls._stripe_object_to_customer(target_cls=Customer, data=data)
         if customer:
             self.customer = customer
-        else:
-            raise ValidationError("A customer was not attached to this charge.")
 
         transfer = cls._stripe_object_to_transfer(target_cls=Transfer, data=data)
         if transfer:

tests/test_charge.py

@@ -9,7 +9,6 @@
 from copy import deepcopy
 from decimal import Decimal
 
-from django.core.exceptions import ValidationError
 from django.test.testcases import TestCase
 from mock import patch
 
@@ -101,8 +100,10 @@ def test_sync_from_stripe_data_no_customer(self, default_account_mock):
         fake_charge_copy = deepcopy(FAKE_CHARGE)
         fake_charge_copy.pop("customer", None)
 
-        with self.assertRaisesMessage(ValidationError, "A customer was not attached to this charge."):
-            Charge.sync_from_stripe_data(fake_charge_copy)
+        Charge.sync_from_stripe_data(fake_charge_copy)
+        assert Charge.objects.count() == 1
+        charge = Charge.objects.get()
+        assert charge.customer is None
 
     @patch("stripe.Charge.retrieve")
     @patch("stripe.Transfer.retrieve")