[Cable] Use sets instead of arrays to store subscription parameters #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arrays were used initially here because they are much more memory efficient than sets. Another reason was that I couldn't reproduce a case where linear complexity searches with `include?` would become problematic. However, with the process of synchronizing subscription parameters between worker processes, using `include?` on Arrays has become a problem. With as little as several thousands of unique subscription identifiers, the time to connect can spike to several seconds. Using sets fixes the issue, and with the number of connections a standard server can handle, the memory difference is negligible.
rsamoilov
force-pushed
the
sets-for-identifiers
branch
from
ae1b3f4 to
6eab03d
Compare
rsamoilov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arrays were used initially here because they are much more memory efficient than sets. Another reason was that I couldn't reproduce a case where linear complexity searches with
include?would become problematic.However, with the process of synchronizing subscription parameters between worker processes, using
include?on arrays has become a problem. With as little as several thousands of unique subscription identifiers, the time to connect can spike to several seconds.Using sets fixes the issue, and with the number of connections a standard server can handle, the memory difference is negligible.