-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default to blocks not allowing wider content inside innerblocks #1408
Conversation
- Introduce dontAllowBlockToBeWiderThanContainerWidth prop to manage block width in Page and Exam components. - Refactor ContentRenderer to destructure props for improved readability and maintainability. - Update InnerBlocks and ConditionalBlock to support inner block width control. - Ensure consistent handling of block width restrictions across components.
WalkthroughThe pull request refactors several components in the course material module by updating how props are handled and passed. Components now destructure properties directly in the parameter list, reducing reliance on the Changes
Sequence Diagram(s)sequenceDiagram
participant Caller as Page/Exam Component
participant CR as ContentRenderer
participant IB as InnerBlocks
Caller->>CR: Render with prop dontAllowBlockToBeWiderThanContainerWidth (false)
Note right of CR: Destructure new props including width control
CR->>IB: Forward dontAllowInnerBlocksToBeWiderThanParentBlock (dynamic/default)
IB-->>CR: Render inner blocks with applied width rules
CR-->>Caller: Output layout with updated rendering rules
Possibly related PRs
Suggested labels
Poem
Tip ⚡🧪 Multi-step agentic review comment chat (experimental)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (8)
⏰ Context from checks skipped due to timeout of 90000ms (4)
🔇 Additional comments (8)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Summary by CodeRabbit
New Features
Refactor