Merge branch '1.2.x'

ragsns · Apr 15, 2015 · 3f44a6f · 3f44a6f
2 parents 825d01e + 764e34b
commit 3f44a6f
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 3 deletions.
diff --git a/.../java/org/springframework/boot/actuate/autoconfigure/EndpointWebMvcAutoConfiguration.java b/.../java/org/springframework/boot/actuate/autoconfigure/EndpointWebMvcAutoConfiguration.java
@@ -66,6 +66,7 @@
 import org.springframework.boot.bind.RelaxedPropertyResolver;
 import org.springframework.boot.context.embedded.AnnotationConfigEmbeddedWebApplicationContext;
 import org.springframework.boot.context.embedded.EmbeddedServletContainerException;
+import org.springframework.boot.context.embedded.EmbeddedWebApplicationContext;
 import org.springframework.boot.context.properties.EnableConfigurationProperties;
 import org.springframework.context.ApplicationContext;
 import org.springframework.context.ApplicationContextAware;
@@ -148,7 +149,9 @@ public void afterSingletonsInstantiated() {
 		ManagementServerPort managementPort = ManagementServerPort
 				.get(this.applicationContext);
 		if (managementPort == ManagementServerPort.DIFFERENT
-				&& this.applicationContext instanceof WebApplicationContext) {
+				&& this.applicationContext instanceof EmbeddedWebApplicationContext
+				&& ((EmbeddedWebApplicationContext) this.applicationContext)
+						.getEmbeddedServletContainer() != null) {
 			createChildManagementContext();
 		}
 		if (managementPort == ManagementServerPort.SAME
@@ -375,8 +378,9 @@ private static class OnEnabledEndpointCondition extends SpringBootCondition {
 		public ConditionOutcome getMatchOutcome(ConditionContext context,
 				AnnotatedTypeMetadata metadata) {
 			AnnotationAttributes annotationAttributes = AnnotationAttributes
-					.fromMap(metadata.getAnnotationAttributes(ConditionalOnEnabledEndpoint.class
-							.getName()));
+					.fromMap(metadata
+							.getAnnotationAttributes(ConditionalOnEnabledEndpoint.class
+									.getName()));
 			String endpointName = annotationAttributes.getString("value");
 			boolean enabledByDefault = annotationAttributes
 					.getBoolean("enabledByDefault");

diff --git a/.../org/springframework/boot/actuate/autoconfigure/EndpointWebMvcAutoConfigurationTests.java b/.../org/springframework/boot/actuate/autoconfigure/EndpointWebMvcAutoConfigurationTests.java
@@ -21,7 +21,9 @@
 import java.net.URI;
 import java.nio.charset.Charset;
 import java.util.List;
+import java.util.Vector;
 
+import javax.servlet.ServletContext;
 import javax.servlet.http.HttpServletRequest;
 import javax.servlet.http.HttpServletResponse;
 
@@ -78,6 +80,8 @@
 import static org.junit.Assert.assertFalse;
 import static org.junit.Assert.assertThat;
 import static org.junit.Assert.assertTrue;
+import static org.mockito.BDDMockito.given;
+import static org.mockito.Mockito.mock;
 
 /**
  * Tests for {@link EndpointWebMvcAutoConfiguration}.
@@ -150,6 +154,24 @@ public void onDifferentPort() throws Exception {
 		assertAllClosed();
 	}
 
+	@Test
+	public void onDifferentPortInServletContainer() throws Exception {
+		this.applicationContext.register(RootConfig.class, EndpointConfig.class,
+				DifferentPortConfig.class, BaseConfiguration.class,
+				EndpointWebMvcAutoConfiguration.class, ErrorMvcAutoConfiguration.class);
+		ServletContext servletContext = mock(ServletContext.class);
+		given(servletContext.getInitParameterNames()).willReturn(
+				new Vector<String>().elements());
+		given(servletContext.getAttributeNames()).willReturn(
+				new Vector<String>().elements());
+		this.applicationContext.setServletContext(servletContext);
+		this.applicationContext.refresh();
+		assertContent("/controller", ports.get().management, null);
+		assertContent("/endpoint", ports.get().management, null);
+		this.applicationContext.close();
+		assertAllClosed();
+	}
+
 	@Test
 	public void onRandomPort() throws Exception {
 		this.applicationContext.register(RootConfig.class, EndpointConfig.class,