MDL-63785 block_html : performance improvement

ragusa87 · Dec 10, 2018 · d426992 · d426992
1 parent e68a25f
commit d426992
Showing 1 changed file with 11 additions and 8 deletions.
diff --git a/blocks/html/classes/privacy/provider.php b/blocks/html/classes/privacy/provider.php
@@ -98,23 +98,26 @@ public static function get_contexts_for_userid(int $userid) : \core_privacy\loca
      * @param   userlist    $userlist   The userlist containing the list of users who have data in this context/plugin combination.
      */
     public static function get_users_in_context(userlist $userlist) {
+        // This block doesn't know who information is stored against unless it
+        // is at the user context.
         $context = $userlist->get_context();
 
-        if (!is_a($context, \context_block::class)) {
+        if (!$context instanceof \context_block) {
             return;
         }
 
+        $sql = "SELECT bpc.instanceid AS userid
+                  FROM {block_instances} bi
+                  JOIN {context} bpc ON bpc.id = bi.parentcontextid
+                 WHERE bi.blockname = 'html'
+                   AND bpc.contextlevel = :contextuser
+                   AND bi.id = :blockinstanceid";
+
         $params = [
-            'contextid'    => $context->id,
             'contextuser' => CONTEXT_USER,
+            'blockinstanceid' => $context->instanceid
         ];
 
-        $sql = "SELECT bpc.instanceid AS userid
-                  FROM {context} c
-                  JOIN {block_instances} bi ON bi.id = c.instanceid AND bi.blockname = 'html'
-                  JOIN {context} bpc ON bpc.id = bi.parentcontextid AND bpc.contextlevel = :contextuser
-                 WHERE c.id = :contextid";
-
         $userlist->add_from_sql('userid', $sql, $params);
     }