MDL-59950 analytics: Use cognitive depth and social breadth constants

ragusa87 · Oct 27, 2017 · ef9f60a · ef9f60a
1 parent db9d745
commit ef9f60a
Show file tree

Hide file tree

Showing 42 changed files with 44 additions and 44 deletions.
diff --git a/mod/assign/classes/analytics/indicator/cognitive_depth.php b/mod/assign/classes/analytics/indicator/cognitive_depth.php
@@ -51,7 +51,7 @@ public function get_indicator_type() {
     }
 
     public function get_cognitive_depth_level(\cm_info $cm) {
-        return 5;
+        return self::COGNITIVE_LEVEL_5;
     }
 
     /**

diff --git a/mod/assign/classes/analytics/indicator/social_breadth.php b/mod/assign/classes/analytics/indicator/social_breadth.php
@@ -51,6 +51,6 @@ public function get_indicator_type() {
     }
 
     public function get_social_breadth_level(\cm_info $cm) {
-        return 2;
+        return self::SOCIAL_LEVEL_2;
     }
 }
diff --git a/mod/book/classes/analytics/indicator/cognitive_depth.php b/mod/book/classes/analytics/indicator/cognitive_depth.php
@@ -51,6 +51,6 @@ public function get_indicator_type() {
     }
 
     public function get_cognitive_depth_level(\cm_info $cm) {
-        return 1;
+        return self::COGNITIVE_LEVEL_1;
     }
 }
diff --git a/mod/book/classes/analytics/indicator/social_breadth.php b/mod/book/classes/analytics/indicator/social_breadth.php
@@ -51,6 +51,6 @@ public function get_indicator_type() {
     }
 
     public function get_social_breadth_level(\cm_info $cm) {
-        return 1;
+        return self::SOCIAL_LEVEL_1;
     }
 }
diff --git a/mod/chat/classes/analytics/indicator/cognitive_depth.php b/mod/chat/classes/analytics/indicator/cognitive_depth.php
@@ -51,6 +51,6 @@ public function get_indicator_type() {
     }
 
     public function get_cognitive_depth_level(\cm_info $cm) {
-        return 4;
+        return self::COGNITIVE_LEVEL_4;
     }
 }
diff --git a/mod/chat/classes/analytics/indicator/social_breadth.php b/mod/chat/classes/analytics/indicator/social_breadth.php
@@ -51,6 +51,6 @@ public function get_indicator_type() {
     }
 
     public function get_social_breadth_level(\cm_info $cm) {
-        return 2;
+        return self::SOCIAL_LEVEL_2;
     }
 }
diff --git a/mod/choice/classes/analytics/indicator/cognitive_depth.php b/mod/choice/classes/analytics/indicator/cognitive_depth.php
@@ -55,9 +55,9 @@ public function get_cognitive_depth_level(\cm_info $cm) {
 
         if ($this->choicedata[$cm->instance]->showresults == 0 || $this->choicedata[$cm->instance]->showresults == 4) {
             // Results are not shown to students or are always shown.
-            return 2;
+            return self::COGNITIVE_LEVEL_2;
         }
 
-        return 3;
+        return self::COGNITIVE_LEVEL_3;
     }
 }
diff --git a/mod/choice/classes/analytics/indicator/social_breadth.php b/mod/choice/classes/analytics/indicator/social_breadth.php
@@ -52,6 +52,6 @@ public function get_indicator_type() {
 
     public function get_social_breadth_level(\cm_info $cm) {
         $this->fill_choice_data($cm);
-        return 2;
+        return self::SOCIAL_LEVEL_2;
     }
 }
diff --git a/mod/data/classes/analytics/indicator/cognitive_depth.php b/mod/data/classes/analytics/indicator/cognitive_depth.php
@@ -51,6 +51,6 @@ public function get_indicator_type() {
     }
 
     public function get_cognitive_depth_level(\cm_info $cm) {
-        return 2;
+        return self::COGNITIVE_LEVEL_2;
     }
 }
diff --git a/mod/data/classes/analytics/indicator/social_breadth.php b/mod/data/classes/analytics/indicator/social_breadth.php
@@ -51,6 +51,6 @@ public function get_indicator_type() {
     }
 
     public function get_social_breadth_level(\cm_info $cm) {
-        return 1;
+        return self::SOCIAL_LEVEL_1;
     }
 }
diff --git a/mod/feedback/classes/analytics/indicator/cognitive_depth.php b/mod/feedback/classes/analytics/indicator/cognitive_depth.php
@@ -55,8 +55,8 @@ public function get_cognitive_depth_level(\cm_info $cm) {
 
         if (!empty($this->publishstats[$cm->instance])) {
             // If stats are published we count that the user viewed feedback.
-            return 3;
+            return self::COGNITIVE_LEVEL_3;
         }
-        return 2;
+        return self::COGNITIVE_LEVEL_2;
     }
 }
diff --git a/mod/feedback/classes/analytics/indicator/social_breadth.php b/mod/feedback/classes/analytics/indicator/social_breadth.php
@@ -53,6 +53,6 @@ public function get_indicator_type() {
     public function get_social_breadth_level(\cm_info $cm) {
         $this->fill_publishstats($cm);
 
-        return 2;
+        return self::SOCIAL_LEVEL_2;
     }
 }
diff --git a/mod/folder/classes/analytics/indicator/cognitive_depth.php b/mod/folder/classes/analytics/indicator/cognitive_depth.php
@@ -51,6 +51,6 @@ public function get_indicator_type() {
     }
 
     public function get_cognitive_depth_level(\cm_info $cm) {
-        return 1;
+        return self::COGNITIVE_LEVEL_1;
     }
 }
diff --git a/mod/folder/classes/analytics/indicator/social_breadth.php b/mod/folder/classes/analytics/indicator/social_breadth.php
@@ -51,6 +51,6 @@ public function get_indicator_type() {
     }
 
     public function get_social_breadth_level(\cm_info $cm) {
-        return 1;
+        return self::SOCIAL_LEVEL_1;
     }
 }
diff --git a/mod/forum/classes/analytics/indicator/cognitive_depth.php b/mod/forum/classes/analytics/indicator/cognitive_depth.php
@@ -51,7 +51,7 @@ public function get_indicator_type() {
     }
 
     public function get_cognitive_depth_level(\cm_info $cm) {
-        return 4;
+        return self::COGNITIVE_LEVEL_4;
     }
 
     /**

diff --git a/mod/forum/classes/analytics/indicator/social_breadth.php b/mod/forum/classes/analytics/indicator/social_breadth.php
@@ -51,6 +51,6 @@ public function get_indicator_type() {
     }
 
     public function get_social_breadth_level(\cm_info $cm) {
-        return 2;
+        return self::SOCIAL_LEVEL_2;
     }
 }
diff --git a/mod/glossary/classes/analytics/indicator/cognitive_depth.php b/mod/glossary/classes/analytics/indicator/cognitive_depth.php
@@ -51,6 +51,6 @@ public function get_indicator_type() {
     }
 
     public function get_cognitive_depth_level(\cm_info $cm) {
-        return 2;
+        return self::COGNITIVE_LEVEL_2;
     }
 }
diff --git a/mod/glossary/classes/analytics/indicator/social_breadth.php b/mod/glossary/classes/analytics/indicator/social_breadth.php
@@ -51,6 +51,6 @@ public function get_indicator_type() {
     }
 
     public function get_social_breadth_level(\cm_info $cm) {
-        return 1;
+        return self::SOCIAL_LEVEL_1;
     }
 }
diff --git a/mod/imscp/classes/analytics/indicator/cognitive_depth.php b/mod/imscp/classes/analytics/indicator/cognitive_depth.php
@@ -51,7 +51,7 @@ public function get_indicator_type() {
     }
 
     public function get_cognitive_depth_level(\cm_info $cm) {
-        return 1;
+        return self::COGNITIVE_LEVEL_1;
     }
 
 }
diff --git a/mod/imscp/classes/analytics/indicator/social_breadth.php b/mod/imscp/classes/analytics/indicator/social_breadth.php
@@ -51,6 +51,6 @@ public function get_indicator_type() {
     }
 
     public function get_social_breadth_level(\cm_info $cm) {
-        return 1;
+        return self::SOCIAL_LEVEL_1;
     }
 }
diff --git a/mod/label/classes/analytics/indicator/cognitive_depth.php b/mod/label/classes/analytics/indicator/cognitive_depth.php
@@ -51,7 +51,7 @@ public function get_indicator_type() {
     }
 
     public function get_cognitive_depth_level(\cm_info $cm) {
-        return 1;
+        return self::COGNITIVE_LEVEL_1;
     }
 
 }
diff --git a/mod/label/classes/analytics/indicator/social_breadth.php b/mod/label/classes/analytics/indicator/social_breadth.php
@@ -51,6 +51,6 @@ public function get_indicator_type() {
     }
 
     public function get_social_breadth_level(\cm_info $cm) {
-        return 1;
+        return self::SOCIAL_LEVEL_1;
     }
 }
diff --git a/mod/lesson/classes/analytics/indicator/cognitive_depth.php b/mod/lesson/classes/analytics/indicator/cognitive_depth.php
@@ -51,7 +51,7 @@ public function get_indicator_type() {
     }
 
     public function get_cognitive_depth_level(\cm_info $cm) {
-        return 5;
+        return self::COGNITIVE_LEVEL_5;
     }
 
     /**

diff --git a/mod/lesson/classes/analytics/indicator/social_breadth.php b/mod/lesson/classes/analytics/indicator/social_breadth.php
@@ -51,6 +51,6 @@ public function get_indicator_type() {
     }
 
     public function get_social_breadth_level(\cm_info $cm) {
-        return 2;
+        return self::SOCIAL_LEVEL_2;
     }
 }
diff --git a/mod/lti/classes/analytics/indicator/cognitive_depth.php b/mod/lti/classes/analytics/indicator/cognitive_depth.php
@@ -51,7 +51,7 @@ public function get_indicator_type() {
     }
 
     public function get_cognitive_depth_level(\cm_info $cm) {
-        return 3;
+        return self::COGNITIVE_LEVEL_3;
     }
 
 }
diff --git a/mod/lti/classes/analytics/indicator/social_breadth.php b/mod/lti/classes/analytics/indicator/social_breadth.php
@@ -51,6 +51,6 @@ public function get_indicator_type() {
     }
 
     public function get_social_breadth_level(\cm_info $cm) {
-        return 2;
+        return self::SOCIAL_LEVEL_2;
     }
 }
diff --git a/mod/page/classes/analytics/indicator/cognitive_depth.php b/mod/page/classes/analytics/indicator/cognitive_depth.php
@@ -51,6 +51,6 @@ public function get_indicator_type() {
     }
 
     public function get_cognitive_depth_level(\cm_info $cm) {
-        return 1;
+        return self::COGNITIVE_LEVEL_1;
     }
 }
diff --git a/mod/page/classes/analytics/indicator/social_breadth.php b/mod/page/classes/analytics/indicator/social_breadth.php
@@ -51,6 +51,6 @@ public function get_indicator_type() {
     }
 
     public function get_social_breadth_level(\cm_info $cm) {
-        return 1;
+        return self::SOCIAL_LEVEL_1;
     }
 }
diff --git a/mod/quiz/classes/analytics/indicator/cognitive_depth.php b/mod/quiz/classes/analytics/indicator/cognitive_depth.php
@@ -51,7 +51,7 @@ public function get_indicator_type() {
     }
 
     public function get_cognitive_depth_level(\cm_info $cm) {
-        return 5;
+        return self::COGNITIVE_LEVEL_5;
     }
 
     /**

diff --git a/mod/quiz/classes/analytics/indicator/social_breadth.php b/mod/quiz/classes/analytics/indicator/social_breadth.php
@@ -51,6 +51,6 @@ public function get_indicator_type() {
     }
 
     public function get_social_breadth_level(\cm_info $cm) {
-        return 2;
+        return self::SOCIAL_LEVEL_2;
     }
 }
diff --git a/mod/resource/classes/analytics/indicator/cognitive_depth.php b/mod/resource/classes/analytics/indicator/cognitive_depth.php
@@ -51,6 +51,6 @@ public function get_indicator_type() {
     }
 
     public function get_cognitive_depth_level(\cm_info $cm) {
-        return 1;
+        return self::COGNITIVE_LEVEL_1;
     }
 }
diff --git a/mod/resource/classes/analytics/indicator/social_breadth.php b/mod/resource/classes/analytics/indicator/social_breadth.php
@@ -51,6 +51,6 @@ public function get_indicator_type() {
     }
 
     public function get_social_breadth_level(\cm_info $cm) {
-        return 1;
+        return self::SOCIAL_LEVEL_1;
     }
 }
diff --git a/mod/scorm/classes/analytics/indicator/cognitive_depth.php b/mod/scorm/classes/analytics/indicator/cognitive_depth.php
@@ -51,6 +51,6 @@ public function get_indicator_type() {
     }
 
     public function get_cognitive_depth_level(\cm_info $cm) {
-        return 3;
+        return self::COGNITIVE_LEVEL_3;
     }
 }
diff --git a/mod/scorm/classes/analytics/indicator/social_breadth.php b/mod/scorm/classes/analytics/indicator/social_breadth.php
@@ -51,6 +51,6 @@ public function get_indicator_type() {
     }
 
     public function get_social_breadth_level(\cm_info $cm) {
-        return 2;
+        return self::SOCIAL_LEVEL_2;
     }
 }
diff --git a/mod/survey/classes/analytics/indicator/cognitive_depth.php b/mod/survey/classes/analytics/indicator/cognitive_depth.php
@@ -51,6 +51,6 @@ public function get_indicator_type() {
     }
 
     public function get_cognitive_depth_level(\cm_info $cm) {
-        return 2;
+        return self::COGNITIVE_LEVEL_2;
     }
 }
diff --git a/mod/survey/classes/analytics/indicator/social_breadth.php b/mod/survey/classes/analytics/indicator/social_breadth.php
@@ -51,6 +51,6 @@ public function get_indicator_type() {
     }
 
     public function get_social_breadth_level(\cm_info $cm) {
-        return 1;
+        return self::SOCIAL_LEVEL_1;
     }
 }
diff --git a/mod/url/classes/analytics/indicator/cognitive_depth.php b/mod/url/classes/analytics/indicator/cognitive_depth.php
@@ -51,6 +51,6 @@ public function get_indicator_type() {
     }
 
     public function get_cognitive_depth_level(\cm_info $cm) {
-        return 1;
+        return self::COGNITIVE_LEVEL_1;
     }
 }
diff --git a/mod/url/classes/analytics/indicator/social_breadth.php b/mod/url/classes/analytics/indicator/social_breadth.php
@@ -51,6 +51,6 @@ public function get_indicator_type() {
     }
 
     public function get_social_breadth_level(\cm_info $cm) {
-        return 1;
+        return self::SOCIAL_LEVEL_1;
     }
 }
diff --git a/mod/wiki/classes/analytics/indicator/cognitive_depth.php b/mod/wiki/classes/analytics/indicator/cognitive_depth.php
@@ -51,6 +51,6 @@ public function get_indicator_type() {
     }
 
     public function get_cognitive_depth_level(\cm_info $cm) {
-        return 2;
+        return self::COGNITIVE_LEVEL_2;
     }
 }
diff --git a/mod/wiki/classes/analytics/indicator/social_breadth.php b/mod/wiki/classes/analytics/indicator/social_breadth.php
@@ -51,6 +51,6 @@ public function get_indicator_type() {
     }
 
     public function get_social_breadth_level(\cm_info $cm) {
-        return 1;
+        return self::SOCIAL_LEVEL_1;
     }
 }
diff --git a/mod/workshop/classes/analytics/indicator/cognitive_depth.php b/mod/workshop/classes/analytics/indicator/cognitive_depth.php
@@ -51,7 +51,7 @@ public function get_indicator_type() {
     }
 
     public function get_cognitive_depth_level(\cm_info $cm) {
-        return 5;
+        return self::COGNITIVE_LEVEL_5;
     }
 
     /**

diff --git a/mod/workshop/classes/analytics/indicator/social_breadth.php b/mod/workshop/classes/analytics/indicator/social_breadth.php
@@ -51,6 +51,6 @@ public function get_indicator_type() {
     }
 
     public function get_social_breadth_level(\cm_info $cm) {
-        return 2;
+        return self::SOCIAL_LEVEL_2;
     }
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -51,7 +51,7 @@ public function get_indicator_type() { @@
         }
         public function get_cognitive_depth_level(\cm_info $cm) {
-            return 5;
+            return self::COGNITIVE_LEVEL_5;
         }
         /**
@@ Expand Down @@