Skip to content

Commit

Permalink
Update to Spring Boot 2
Browse files Browse the repository at this point in the history
This change does an basic update to Spring Boot 2.2.10 and booterizes some
dependencies to be handled under Spring Boot's dependency managment. This
will make future updates easier, as the components in a Spring Boot
release cycle is (somewhat) tested to be compatible. The reason this
update did not go to Spring Boot 2.3.x at once is that I think it is
better to take small steps to iron out upgrade bugs.
  • Loading branch information
janderssonse committed Nov 13, 2020
1 parent a62c331 commit c8d2864
Show file tree
Hide file tree
Showing 15 changed files with 21 additions and 28 deletions.
23 changes: 8 additions & 15 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
<description>For when you have a Kafka cluster to monitor</description>

<properties>
<spring.boot.version>2.1.8.RELEASE</spring.boot.version>
<spring.boot.version>2.2.10.RELEASE</spring.boot.version>
<additionalparam>-Xdoclint:none</additionalparam>

<!-- name of parameter changed in latest mvn javadoc plugin version-->
Expand Down Expand Up @@ -86,16 +86,6 @@
<artifactId>lombok</artifactId>
<version>1.18.8</version>
</dependency>
<dependency>
<groupId>org.apache.kafka</groupId>
<artifactId>kafka-clients</artifactId>
<version>2.3.1</version>
</dependency>
<dependency>
<groupId>org.freemarker</groupId>
<artifactId>freemarker</artifactId>
<version>2.3.28</version>
</dependency>
<dependency>
<groupId>io.confluent</groupId>
<artifactId>kafka-avro-serializer</artifactId>
Expand Down Expand Up @@ -133,18 +123,21 @@
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>org.springframework.kafka</groupId>
<artifactId>spring-kafka</artifactId>
</dependency>
<dependency>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-starter-undertow</artifactId>
</dependency>
<dependency>
<groupId>io.undertow</groupId>
<artifactId>undertow-core</artifactId>
<version>2.0.26.Final</version>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-starter-freemarker</artifactId>
</dependency>
<dependency>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-starter-freemarker</artifactId>
<artifactId>spring-boot-starter-undertow</artifactId>
</dependency>
<dependency>
<groupId>org.springframework.boot</groupId>
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/kafdrop/config/HealthCheckConfiguration.java
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public HealthCheck(HealthEndpoint healthEndpoint) {

@ManagedAttribute
public Map getHealth() {
final var health = healthEndpoint.health();
final var health = (Health) healthEndpoint.health();
final var healthMap = new LinkedHashMap<String, Object>();
healthMap.put("status", getStatus(health));
healthMap.put("detail", getDetails(health.getDetails()));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
limitations under the License.
-->
<#import "/spring.ftl" as spring />
<#import "lib/template.ftl" as template>
<#import "lib/template.ftlh" as template>
<@template.header "ACLs">
<style type="text/css">
.bs-table.overview td {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
limitations under the License.
-->
<#import "/spring.ftl" as spring />
<#import "lib/template.ftl" as template>
<#import "lib/template.ftlh" as template>
<@template.header "Broker: ${broker.id?string}">
<style type="text/css">
.bs-table.overview td {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
limitations under the License.
-->
<#import "/spring.ftl" as spring />
<#import "lib/template.ftl" as template>
<#import "lib/template.ftlh" as template>
<@template.header "Broker List"/>

<script src="<@spring.url '/js/powerFilter.js'/>"></script>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
limitations under the License.
-->
<#import "/spring.ftl" as spring />
<#import "lib/template.ftl" as template>
<#import "lib/template.ftlh" as template>
<@template.header "Consumer: ${consumer.groupId}"/>

<#setting number_format="0">
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<#import "/spring.ftl" as spring />
<#import "lib/template.ftl" as template>
<#import "lib/template.ftlh" as template>
<@template.header "${error.error}"/>
<h2>${error.error}</h2>
<div id="errorHeader">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,13 @@
<#nested>
</head>
<body>
<#include "../includes/header.ftl">
<#include "../includes/header.ftlh">
<div class="container">
</#macro>

<#macro footer>
</div>
<#include "../includes/footer.ftl">
<#include "../includes/footer.ftlh">
<#nested>
</body>
</html>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
limitations under the License.
-->
<#import "/spring.ftl" as spring />
<#import "lib/template.ftl" as template>
<#import "lib/template.ftlh" as template>
<@template.header "Topic: ${topic.name}: Messages">
<style type="text/css">
h2 {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
See the License for the specific language governing permissions and
limitations under the License.
-->
<#import "lib/template.ftl" as template>
<#import "lib/template.ftlh" as template>
<@template.header "Initializing...">
<meta http-equiv="refresh" content="5">
</@template.header>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
limitations under the License.
-->
<#import "/spring.ftl" as spring />
<#import "lib/template.ftl" as template>
<#import "lib/template.ftlh" as template>
<@template.header "Topic create"/>

<script src="<@spring.url '/js/powerFilter.js'/>"></script>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
limitations under the License.
-->
<#import "/spring.ftl" as spring />
<#import "lib/template.ftl" as template>
<#import "lib/template.ftlh" as template>
<@template.header "Topic: ${topic.name}">
<style type="text/css">
#action-bar {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
limitations under the License.
-->
<#import "/spring.ftl" as spring />
<#import "lib/template.ftl" as template>
<#import "lib/template.ftlh" as template>

<@template.header "Topic: ${topic.name}: Messages">
<style type="text/css">
Expand Down

0 comments on commit c8d2864

Please sign in to comment.