Prevent fake banned messages

rahulsom · Sep 3, 2017 · 17baf46 · 17baf46
1 parent f0ed786
commit 17baf46
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/src/main/webapp/WEB-INF/groovy/store.groovy b/src/main/webapp/WEB-INF/groovy/store.groovy
@@ -20,8 +20,8 @@ if (githubAuthUtil.isAuthenticated()) {
             uploader: username,
             uploaderEmail: session.getAttribute(GithubAuthUtil.GITHUB_EMAIL_PRIMARY)
     )
+    UserList myList = LgtmService.instance.getUserList(username)
     try {
-        UserList myList = LgtmService.instance.getUserList(username)
 
         if (myList.bannedFromUpload) {
             request.setAttribute 'message', "You're not allowed to upload images"
@@ -46,6 +46,7 @@ if (githubAuthUtil.isAuthenticated()) {
         request.setAttribute 'message', 'That image was already uploaded.'
         redirect "/i/${e.hash}"
     } catch (ValidationException e) {
+        request.setAttribute('banned', myList.bannedFromUpload)
         request.setAttribute 'message', e.message
         request.setAttribute 'imageUrl', imageUrl
         response.setHeader "Content-Type", "text/html"

diff --git a/src/main/webapp/WEB-INF/pages/upload.gtpl b/src/main/webapp/WEB-INF/pages/upload.gtpl
@@ -5,7 +5,11 @@
     <body>
         <h1>Upload</h1>
 
-        <% if (request.getAttribute('banned') == false) { %>
+        <% if (request.getAttribute('banned') == true) { %>
+            <div class="alert alert-warning" role="alert">
+                You have been banned from uploading images for violating our content policy. You may still use
+            </div>
+        <% } else { %>
             <form action="/save" method="post">
                 <div class="form-group>
                     <label for="imageUrl">Image Url</label>
@@ -17,10 +21,6 @@
                 </div>
                 <button type="submit" class="btn btn-default">Submit</button>
             </form>
-        <% } else { %>
-            <div class="alert alert-warning" role="alert">
-                You have been banned from uploading images for violating our content policy. You may still use
-            </div>
         <% } %>
     </body>
 </html>