Skip to content

Commit

Permalink
win_firewall_rule: Implement idempotency, check-mode and diff support (
Browse files Browse the repository at this point in the history
…ansible#23162)

* win_firewall_rule: Small idempotency fix

This PR includes the following changes:
- an idempotency fix when `profile: any`
- better difference output to debug idempotency issues
- documentation fixes (remove `required: false`)
- Parameter handling fixes
- RDP example that matches default RDP rule
- Renamed parameter 'enable' to 'enabled' (kept alias)
- Renamed parameter 'profile' to 'profiles' (kept alias)

* Rewrite module completely

The logic is still intact, but various changes with a single goal:

- Make the module idempotent
- Implement check-mode
- Implement diff-mode
- Adapted integration tests

This fixes ansible#18807 and ansible#23455.

* Change casing to lowercase

* Improve the logic wrt. diff
  • Loading branch information
dagwieers authored and nitzmahone committed May 30, 2017
1 parent 0e160d5 commit d958440
Show file tree
Hide file tree
Showing 3 changed files with 445 additions and 409 deletions.
Loading

0 comments on commit d958440

Please sign in to comment.