fix speedgrader crash with post policies if no submission object

fixes GRADE-2292 test plan: - Have a course with an assignment and a few students - In the rails console, delete the submission object for one of the students. - Note that speedgrader loads normally Change-Id: I14949ba8e1f033475afd0b9d8e9ffdf39d12e2c7 Reviewed-on: https://gerrit.instructure.com/201125 Tested-by: Jenkins QA-Review: Keith Garner <[email protected]> Product-Review: Keith Garner <[email protected]> Reviewed-by: Gary Mei <[email protected]> Reviewed-by: Adrian Packel <[email protected]>
ralacas · Jul 13, 2019 · 32b2070 · 32b2070
1 parent 4d5d878
commit 32b2070
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/public/javascripts/speed_grader.js b/public/javascripts/speed_grader.js
@@ -3688,8 +3688,8 @@ function teardownSettingsMenu() {
 function renderPostGradesMenu() {
   const {submissionsMap} = window.jsonData
   const submissions = window.jsonData.studentsWithSubmissions.map(student => student.submission)
-  const allowHidingGrades = submissions.some(submission => submission.posted_at != null)
-  const allowPostingGrades = submissions.some(submission => submission.posted_at == null)
+  const allowHidingGrades = submissions.some(submission => submission && submission.posted_at != null)
+  const allowPostingGrades = submissions.some(submission => submission && submission.posted_at == null)
 
   function onHideGrades() {
     EG.postPolicies.showHideAssignmentGradesTray({submissionsMap})