Skip to content

Commit

Permalink
enable graphql feature flag
Browse files Browse the repository at this point in the history
refs RECNVS-332

Test plan:
  * make sure graphql is turned on for accounts that previously had
    graphql enabled and then disabled
  * make sure graphql can't be turned off

Change-Id: I36b56d7286b30e98f1adfd898886cc29e66fa0e2
Reviewed-on: https://gerrit.instructure.com/142219
Tested-by: Jenkins
Reviewed-by: Michael Jasper <[email protected]>
QA-Review: Jonathan Featherstone <[email protected]>
Product-Review: Cameron Matheson <[email protected]>
  • Loading branch information
cmatheson committed Feb 28, 2018
1 parent c0f7e33 commit c35e13f
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 12 deletions.
2 changes: 1 addition & 1 deletion lib/feature.rb
Original file line number Diff line number Diff line change
Expand Up @@ -582,7 +582,7 @@ def self.register(feature_hash)
display_name: -> { I18n.t("GraphQL API") },
description: -> { I18n.t("EXPERIMENTAL GraphQL API.") },
applies_to: "RootAccount",
state: "hidden_in_prod",
state: "on",
beta: true,
},
'rubric_criterion_range' =>
Expand Down
11 changes: 0 additions & 11 deletions spec/controllers/graphql_controller_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -24,17 +24,6 @@
student_in_course
end

context "feature flag is disabled" do
before { user_session(@student) }

it "404s for all endpoints" do
%w[graphiql execute].each do |endpoint|
get endpoint
expect(response.status).to eq 404
end
end
end

context "graphiql" do
before { Account.default.enable_feature!("graphql") }

Expand Down

0 comments on commit c35e13f

Please sign in to comment.