Explicit template parameters

Summary:
uniform_int_distribution has undefined behavior (UB) if data type is not one of short, int, long, long long, unsigned short, unsigned int, unsigned long, or unsigned long long.

MSVC is strict about UB and doesn't allow uint8_t.

MSVC also can't deduce one of the template parameter. Adding it explicitly.

Reviewed By: protonu

Differential Revision: D18940804

fbshipit-source-id: 839f97d6437a4f7011b2334f85d8e1a4dd329ec8

bench/BenchUtils.cc

@@ -21,7 +21,7 @@ std::default_random_engine eng;
 
 template <typename T>
 void randFill(aligned_vector<T>& vec, T low, T high, std::true_type) {
-  std::uniform_int_distribution<T> dis(low, high);
+  std::uniform_int_distribution<int> dis(low, high);
   std::generate(vec.begin(), vec.end(), [&] { return dis(eng); });
 }
 

test/I64Test.cc

@@ -85,7 +85,8 @@ TEST_F(Int64GemmTest, test) {
               C_ref.data(),
               n);
 
-          compare_validate_buffers(C_ref.data(), C.data(), m, n, n, 0L);
+          compare_validate_buffers<int64_t>(
+              C_ref.data(), C.data(), m, n, n, 0L);
         }
       } // transb
     } // transa