Remove HTTP config server closes #2988

src/github.com/getlantern/flashlight/config/config.go

@@ -83,7 +83,6 @@ func Init(version string) (*Config, error) {
 	m = &yamlconf.Manager{
 		FilePath:         configPath,
 		FilePollInterval: 1 * time.Second,
-		ConfigServerAddr: *configaddr,
 		EmptyConfig: func() yamlconf.Config {
 			return &Config{}
 		},

src/github.com/getlantern/flashlight/config/flags.go

@@ -11,7 +11,6 @@ import (
 
 var (
 	configdir     = flag.String("configdir", "", "directory in which to store configuration, including flashlight.yaml (defaults to current directory)")
-	configaddr    = flag.String("configaddr", "", "if specified, run an http-based configuration server at this address")
 	cloudconfig   = flag.String("cloudconfig", "", "optional http(s) URL to a cloud-based source for configuration updates")
 	cloudconfigca = flag.String("cloudconfigca", "", "optional PEM encoded certificate used to verify TLS connections to fetch cloudconfig")
 	addr          = flag.String("addr", "", "ip:port on which to listen for requests. When running as a client proxy, we'll listen with http, when running as a server proxy we'll listen with https (required)")

src/github.com/getlantern/yamlconf/yamlconf.go

@@ -94,10 +94,6 @@ type Manager struct {
 	// to 1 second
 	FilePollInterval time.Duration
 
-	// ConfigServerAddr: optionally, specify an address at which to provide a
-	// RESTFUL HTTP server for making config updates.
-	ConfigServerAddr string
-
 	// EmptyConfig: required, factor for new empty Configs
 	EmptyConfig func() Config
 
@@ -192,13 +188,6 @@ func (m *Manager) Init() (Config, error) {
 
 	go m.processUpdates()
 
-	if m.ConfigServerAddr != "" {
-		err = m.startConfigServer()
-		if err != nil {
-			return nil, err
-		}
-	}
-
 	return m.getCfg(), nil
 }