Meraki - Remove type comparison for idempotency check (ansible#65338)

* Remove type comparison in is_update_required() * Add changelog
raphaelm · Dec 4, 2019 · 79b088a · 79b088a
1 parent f4a9f23
commit 79b088a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/changelogs/fragments/meraki-dont-compare-type.yml b/changelogs/fragments/meraki-dont-compare-type.yml
@@ -0,0 +1,2 @@
+minor_changes:
+  - meraki - Idempotency check no longer compares types of objects 
diff --git a/lib/ansible/module_utils/network/meraki/meraki.py b/lib/ansible/module_utils/network/meraki/meraki.py
@@ -230,9 +230,6 @@ def is_update_required(self, original, proposed, optional_ignore=None):
         if optional_ignore is not None:
             self.ignored_keys = self.ignored_keys + optional_ignore
 
-        if type(original) != type(proposed):
-            # self.fail_json(msg="Types don't match")
-            return True
         if isinstance(original, list):
             if len(original) != len(proposed):
                 # self.fail_json(msg="Length of lists don't match")
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		minor_changes:
		- meraki - Idempotency check no longer compares types of objects