Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Legacy UDP port status detection algorithm support OUTDATED #1

Merged
merged 3 commits into from
Jun 29, 2021
Merged

Legacy UDP port status detection algorithm support OUTDATED #1

merged 3 commits into from
Jun 29, 2021

Conversation

jsteers-r7
Copy link

@jsteers-r7 jsteers-r7 commented Jun 17, 2021 •
edited
Loading

This patch provides the following custom functionality:

  • Legacy UDP port detection: performs post processing on UDP port results to determine if an OPEN|FILTERED response should be considered OPEN or FILTERED based on the ratio of closed UDP ports compared to UDP ports which had responded. (see output.cc)
  • Allow logging for all port statuses (see portlist.cc)

@jsteers-r7 jsteers-r7 changed the base branch from master to release June 28, 2021 15:33
@jsteers-r7 jsteers-r7 changed the base branch from release to master June 28, 2021 15:35
@jsteers-r7 jsteers-r7 changed the base branch from master to release June 28, 2021 16:00
@jsteers-r7 jsteers-r7 force-pushed the legacy-udp-port-status-detection-algorithm branch from 2be261b to 1b2e5cc Compare June 28, 2021 16:02
@jsteers-r7 jsteers-r7 merged commit cac20d7 into rapid7:release Jun 29, 2021
@jsteers-r7
Copy link
Author

jsteers-r7 commented Jun 29, 2021 •
edited
Loading

Note: amended commit cac20d7 due to duplicate code in output.cc post-merge, new commit hash for Legacy Port Status update is cb60df6

@jsteers-r7 jsteers-r7 deleted the legacy-udp-port-status-detection-algorithm branch July 5, 2021 10:28
@jsteers-r7 jsteers-r7 changed the title Legacy UDP port status detection algorithm support Legacy UDP port status detection algorithm support OUTDATED Jul 5, 2021
@jsteers-r7
Copy link
Author

Following previous merge issues new PR has been opened here: #2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekelly-1898 ekelly-1898 ekelly-1898 approved these changes

@amcclenaghan-r7 amcclenaghan-r7 amcclenaghan-r7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsteers-r7 @ekelly-1898 @amcclenaghan-r7