Merge pull request moby#39250 from shuchow/706-cifs-lookup

Enable DNS Lookups for CIFS Volumes
rasata · Sep 3, 2019 · a114a2c · a114a2c
2 parents 1a117b8 + 75a59c6
commit a114a2c
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/volume/local/local_unix.go b/volume/local/local_unix.go
@@ -97,11 +97,12 @@ func (v *localVolume) mount() error {
 		return fmt.Errorf("missing device in volume options")
 	}
 	mountOpts := v.opts.MountOpts
-	if v.opts.MountType == "nfs" {
+	switch v.opts.MountType {
+	case "nfs", "cifs":
 		if addrValue := getAddress(v.opts.MountOpts); addrValue != "" && net.ParseIP(addrValue).To4() == nil {
 			ipAddr, err := net.ResolveIPAddr("ip", addrValue)
 			if err != nil {
-				return errors.Wrapf(err, "error resolving passed in nfs address")
+				return errors.Wrapf(err, "error resolving passed in network volume address")
 			}
 			mountOpts = strings.Replace(mountOpts, "addr="+addrValue, "addr="+ipAddr.String(), 1)
 		}