Skip to content

Commit

Permalink
Merge pull request Shopify#2836 from Shopify/make-dev2-default
Browse files Browse the repository at this point in the history
Make dev2 default
  • Loading branch information
Arkham authored Sep 18, 2023
2 parents 43fb5fc + d54073b commit 0076ec8
Show file tree
Hide file tree
Showing 7 changed files with 281 additions and 1,057 deletions.
14 changes: 2 additions & 12 deletions packages/app/src/cli/commands/app/dev.ts
Original file line number Diff line number Diff line change
@@ -1,15 +1,11 @@
import {appFlags} from '../../flags.js'
import dev from '../../services/dev.js'
import {dev as dev2} from '../../services/dev2.js'
import {dev} from '../../services/dev.js'
import Command from '../../utilities/app-command.js'
import {showApiKeyDeprecationWarning} from '../../prompts/deprecation-warnings.js'
import {Flags} from '@oclif/core'
import {normalizeStoreFqdn} from '@shopify/cli-kit/node/context/fqdn'
import {globalFlags} from '@shopify/cli-kit/node/cli'
import {addPublicMetadata} from '@shopify/cli-kit/node/metadata'
import {isTruthy} from '@shopify/cli-kit/node/context/utilities'
import {getEnvironmentVariables} from '@shopify/cli-kit/node/environment'
import {isShopify} from '@shopify/cli-kit/node/context/local'

export default class Dev extends Command {
static description = 'Run the app.'
Expand Down Expand Up @@ -134,12 +130,6 @@ export default class Dev extends Command {
notify: flags.notify,
}

const enableNewDev = getEnvironmentVariables().SHOPIFY_CLI_NEW_DEV

if (isTruthy(enableNewDev) || (enableNewDev === undefined && (await isShopify()))) {
await dev2(devOptions)
} else {
await dev(devOptions)
}
await dev(devOptions)
}
}
142 changes: 0 additions & 142 deletions packages/app/src/cli/services/dev.test.ts

This file was deleted.

Loading

0 comments on commit 0076ec8

Please sign in to comment.