Skip to content

Commit

Permalink
fixed some typos in README.md
Browse files Browse the repository at this point in the history
  • Loading branch information
ifsnop committed Feb 18, 2019
1 parent 8496fbb commit 0842d0d
Showing 1 changed file with 7 additions and 5 deletions.
12 changes: 7 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -303,12 +303,14 @@ Current code for testing is an ugly hack. Probably there are much better ways
of doing them using PHPUnit, so PR's are welcomed. The testing script creates
and populates a database using all possible datatypes. Then it exports it
using both mysqldump-php and mysqldump, and compares the output. Only if
it is identical tests are OK.
it is identical tests are OK. After [this](https://github.com/ifsnop/mysqldump-php/commit/8496fbb1b26dde404804bc8865ec32044da5b813)
commit, some test are performed using phpunit.

Some tests are skipped if mysql server doesn't support them.

A couple of tests are only compared between original sql code and
mysqldump-php, because mysqldump doesn't work,
A couple of tests are only comparing between original sql code and
mysqldump-php generated sql, because some options are not available in
mysqldump.

## Bugs (from mysqldump, not from mysqldump-php)

Expand All @@ -319,9 +321,9 @@ used, if the value is empty.
## Backporting

mysqldump-php is not backwards compatible with php 5.2 because we it uses
namespaces. It can be trivially fixed.
namespaces. However, it could be trivially fixed if needed.

## TODO
## Todo

Write more tests, test with mariadb also.

Expand Down

0 comments on commit 0842d0d

Please sign in to comment.