Merge pull request ifsnop#167 from andreas-glaser/fix-lock-tables

Adds 40100 WITH CONSISTENT SNAPSHOT to transaction start
raubinjake · Aug 5, 2019 · 92bdf13 · 92bdf13
2 parents d3bd1aa + 2ece02c
commit 92bdf13
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/src/Ifsnop/Mysqldump/Mysqldump.php b/src/Ifsnop/Mysqldump/Mysqldump.php
@@ -1180,7 +1180,7 @@ public function prepareListValues($tableName)
             $this->dbHandler->exec($this->typeAdapter->start_transaction());
         }
 
-        if ($this->dumpSettings['lock-tables']) {
+        if ($this->dumpSettings['lock-tables'] && !$this->dumpSettings['single-transaction']) {
             $this->typeAdapter->lock_table($tableName);
         }
 
@@ -1232,7 +1232,7 @@ public function endListValues($tableName, $count = 0)
             $this->dbHandler->exec($this->typeAdapter->commit_transaction());
         }
 
-        if ($this->dumpSettings['lock-tables']) {
+        if ($this->dumpSettings['lock-tables'] && !$this->dumpSettings['single-transaction']) {
             $this->typeAdapter->unlock_table($tableName);
         }
 
@@ -2054,9 +2054,11 @@ public function setup_transaction()
 
     public function start_transaction()
     {
-        return "START TRANSACTION";
+        return "START TRANSACTION " .
+            "/*!40100 WITH CONSISTENT SNAPSHOT */";
     }
 
+
     public function commit_transaction()
     {
         return "COMMIT";