gitweb: escape tag comments

I have a tag with a comment which includes an & character. Firefox wouldn't display my gitweb summary page due to malformed XML. This solves the problem. Signed-off-by: Daniel Drake <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
ravibrk · Jul 25, 2006 · 143c89b · 143c89b
1 parent 09f5dc4
commit 143c89b
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/gitweb/gitweb.cgi b/gitweb/gitweb.cgi
@@ -1138,7 +1138,7 @@ sub git_summary {
 				      "</td>\n" .
 				      "<td>";
 				if (defined($comment)) {
-				      print $cgi->a({-class => "list", -href => "$my_uri?" . esc_param("p=$project;a=tag;h=$tag{'id'}")}, $comment);
+				      print $cgi->a({-class => "list", -href => "$my_uri?" . esc_param("p=$project;a=tag;h=$tag{'id'}")}, esc_html($comment));
 				}
 				print "</td>\n" .
 				      "<td class=\"link\">";