crypto/rsa: return error if keygen random source is broken

Fixes golang#70643 Change-Id: I47c76500bb2e79b0d1dc096651eb45885f6888b6 Reviewed-on: https://go-review.googlesource.com/c/go/+/632896 Reviewed-by: Russ Cox <[email protected]> Reviewed-by: Roland Shoemaker <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Auto-Submit: Filippo Valsorda <[email protected]>
rayyildiz · Dec 3, 2024 · 485ed2f · 485ed2f
1 parent 106c804
commit 485ed2f
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/src/crypto/internal/fips140/rsa/keygen.go b/src/crypto/internal/fips140/rsa/keygen.go
@@ -45,6 +45,10 @@ func GenerateKey(rand io.Reader, bits int) (*PrivateKey, error) {
 			return nil, err
 		}
 
+		if Q.Nat().ExpandFor(P).Equal(P.Nat()) == 1 {
+			return nil, errors.New("rsa: generated p == q, random source is broken")
+		}
+
 		N, err := bigmod.NewModulusProduct(p, q)
 		if err != nil {
 			return nil, err