MDL-59887 block_myoverview: dont escape course and module names

rboyatt · Aug 24, 2017 · b9d7df7 · b9d7df7
1 parent 27466d7
commit b9d7df7
Show file tree

Hide file tree

Showing 6 changed files with 17 additions and 13 deletions.
diff --git a/blocks/myoverview/templates/course-event-list.mustache b/blocks/myoverview/templates/course-event-list.mustache
@@ -97,7 +97,7 @@
              role="presentation">
         <p class="text-muted m-t-1">{{#str}} noevents, block_myoverview {{/str}}</p>
         <a href="{{viewurl}}" class="btn btn-secondary {{#visible}}text-primary{{/visible}}"
-           aria-label="{{#str}} viewcoursename, block_myoverview, {{fullnamedisplay}} {{/str}}">
+           aria-label="{{#str}} viewcoursename, block_myoverview, {{{fullnamedisplay}}} {{/str}}">
             {{#str}} viewcourse, block_myoverview {{/str}}
         </a>
     </div>

diff --git a/theme/bootstrapbase/templates/block_myoverview/course-event-list-item.mustache b/theme/bootstrapbase/templates/block_myoverview/course-event-list-item.mustache
@@ -46,7 +46,7 @@
                 {{#icon}}{{#pix}} {{key}}, {{component}}, {{alttext}} {{/pix}}{{/icon}}
             </div>
             <div class="d-inline-block event-name-container">
-                <a class="event-name text-truncate" href="{{{url}}}">{{name}}</a>
+                <a class="event-name text-truncate" href="{{{url}}}">{{{name}}}</a>
                 <div class="muted text-truncate">
                     <small>{{#userdate}} {{timesort}}, {{#str}} strftimerecent {{/str}} {{/userdate}}</small>
                 </div>
@@ -72,7 +72,7 @@
                 {{#icon}}{{#pix}} {{key}}, {{component}}, {{alttext}} {{/pix}}{{/icon}}
             </div>
             <div class="d-inline-block event-name-container">
-                <a class="event-name text-truncate" href="{{{url}}}">{{name}}</a>
+                <a class="event-name text-truncate" href="{{{url}}}">{{{name}}}</a>
                 <div class="muted text-truncate">
                     <small>{{#userdate}} {{timesort}}, {{#str}} strftimerecent {{/str}} {{/userdate}}</small>
                 </div>
@@ -85,7 +85,7 @@
                 {{#icon}}{{#pix}} {{key}}, {{component}}, {{alttext}} {{/pix}}{{/icon}}
             </div>
             <div class="d-inline-block event-name-container">
-                <a class="event-name text-truncate" href="{{{url}}}">{{name}}</a>
+                <a class="event-name text-truncate" href="{{{url}}}">{{{name}}}</a>
                 <div class="muted text-truncate">
                     <small>{{#userdate}} {{timesort}}, {{#str}} strftimerecent {{/str}} {{/userdate}}</small>
                 </div>

diff --git a/theme/bootstrapbase/templates/block_myoverview/course-event-list.mustache b/theme/bootstrapbase/templates/block_myoverview/course-event-list.mustache
@@ -97,7 +97,7 @@
              role="presentation">
         <p class="text-muted m-t-1">{{#str}} noevents, block_myoverview {{/str}}</p>
         <a href="{{viewurl}}" class="btn"
-           aria-label="{{#str}} viewcoursename, block_myoverview, {{fullnamedisplay}} {{/str}}">
+           aria-label="{{#str}} viewcoursename, block_myoverview, {{{fullnamedisplay}}} {{/str}}">
             {{#str}} viewcourse, block_myoverview {{/str}}
         </a>
     </div>

diff --git a/theme/bootstrapbase/templates/block_myoverview/course-summary.mustache b/theme/bootstrapbase/templates/block_myoverview/course-summary.mustache
@@ -29,7 +29,7 @@
 <div class="course-info-container" id="course-info-container-{{id}}">
     <div class="visible-desktop">
         {{> block_myoverview/progress-chart}}
-        <h4><a href="{{viewurl}}" class="{{^visible}}dimmed{{/visible}}">{{fullnamedisplay}}</a></h4>
+        <h4><a href="{{viewurl}}" class="{{^visible}}dimmed{{/visible}}">{{{fullnamedisplay}}}</a></h4>
     </div>
     <div class="hidden-desktop">
         <div class="media">
@@ -39,7 +39,9 @@
                 </div>
             </div>
             <div class="media-body">
-                <h4 class="media-heading"><a href="{{viewurl}}" class="{{^visible}}dimmed{{/visible}}">{{fullnamedisplay}}</a></h4>
+                <h4 class="media-heading">
+                    <a href="{{viewurl}}" class="{{^visible}}dimmed{{/visible}}">{{{fullnamedisplay}}}</a>
+                </h4>
             </div>
         </div>
     </div>

diff --git a/theme/bootstrapbase/templates/block_myoverview/courses-view-course-item.mustache b/theme/bootstrapbase/templates/block_myoverview/courses-view-course-item.mustache
@@ -35,7 +35,9 @@
                 </div>
             </div>
             <div class="media-body">
-                <h4 class="media-heading"><a href="{{viewurl}}" class="{{^visible}}dimmed{{/visible}}">{{fullnamedisplay}}</a></h4>
+                <h4 class="media-heading">
+                    <a href="{{viewurl}}" class="{{^visible}}dimmed{{/visible}}">{{{fullnamedisplay}}}</a>
+                </h4>
             </div>
         </div>
         <p class="text-muted">

diff --git a/theme/bootstrapbase/templates/block_myoverview/event-list-item.mustache b/theme/bootstrapbase/templates/block_myoverview/event-list-item.mustache
@@ -48,8 +48,8 @@
                 {{#icon}}{{#pix}} {{key}}, {{component}}, {{alttext}} {{/pix}}{{/icon}}
             </div>
             <div class="d-inline-block event-name-container">
-                <a class="event-name text-truncate" href="{{{url}}}">{{name}}</a>
-                <div class="muted text-truncate"><small>{{course.fullnamedisplay}}</small></div>
+                <a class="event-name text-truncate" href="{{{url}}}">{{{name}}}</a>
+                <div class="muted text-truncate"><small>{{{course.fullnamedisplay}}}</small></div>
             </div>
         </div>
         <div class="span6">
@@ -80,7 +80,7 @@
             </div>
             <div class="d-inline-block event-name-container">
                 <a class="event-name text-truncate" href="{{{url}}}">{{name}}</a>
-                <div class="muted text-truncate"><small>{{course.fullnamedisplay}}</small></div>
+                <div class="muted text-truncate"><small>{{{course.fullnamedisplay}}}</small></div>
             </div>
         </div>
         <div class="span4 text-right text-truncate">
@@ -93,8 +93,8 @@
                 {{#icon}}{{#pix}} {{key}}, {{component}}, {{alttext}} {{/pix}}{{/icon}}
             </div>
             <div class="d-inline-block event-name-container">
-                <a class="event-name text-truncate" href="{{{url}}}">{{name}}</a>
-                <div class="muted text-truncate"><small>{{course.fullnamedisplay}}</small></div>
+                <a class="event-name text-truncate" href="{{{url}}}">{{{name}}}</a>
+                <div class="muted text-truncate"><small>{{{course.fullnamedisplay}}}</small></div>
             </div>
             <div class="text-right text-truncate">
                 {{#userdate}} {{timesort}}, {{#str}} strftimerecent {{/str}} {{/userdate}}