Skip to content

Commit

Permalink
Merge pull request grpc#10397 from grpc/ctiller-patch-1
Browse files Browse the repository at this point in the history
Loosen constraints for reporting
  • Loading branch information
ctiller authored Mar 31, 2017
2 parents 24eab2a + a77023b commit 55fd663
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions tools/profiling/microbenchmarks/bm_diff.py
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,8 @@ def min_change(pct):
return lambda n, o: abs(changed_ratio(n,o)) > pct/100.0

nanos = {
'abs_diff': 10,
'pct_diff': 10,
'abs_diff': 5,
'pct_diff': 5,
}
counter = {
'abs_diff': 1,
Expand Down Expand Up @@ -101,8 +101,8 @@ def min_change(pct):
help='Which metrics to track')
argp.add_argument('-b', '--benchmarks', nargs='+', choices=_AVAILABLE_BENCHMARK_TESTS, default=['bm_cq'])
argp.add_argument('-d', '--diff_base', type=str)
argp.add_argument('-r', '--repetitions', type=int, default=7)
argp.add_argument('-p', '--p_threshold', type=float, default=0.01)
argp.add_argument('-r', '--repetitions', type=int, default=4)
argp.add_argument('-p', '--p_threshold', type=float, default=0.05)
args = argp.parse_args()

assert args.diff_base
Expand Down

0 comments on commit 55fd663

Please sign in to comment.