🚸 Validate minimum uid length (laminlabs#2144)

lamindb/_record.py

@@ -5,6 +5,7 @@
 
 import dj_database_url
 import lamindb_setup as ln_setup
+from django.core.exceptions import FieldDoesNotExist
 from django.db import connections, transaction
 from django.db.models import IntegerField, Manager, Q, QuerySet, Value
 from lamin_utils import colors, logger
@@ -21,7 +22,7 @@
 
 from ._utils import attach_func_to_class_method
 from .core._settings import settings
-from .core.exceptions import RecordNameChangeIntegrityError
+from .core.exceptions import RecordNameChangeIntegrityError, ValidationError
 
 if TYPE_CHECKING:
     import pandas as pd
@@ -58,6 +59,16 @@ def validate_required_fields(record: Record, kwargs):
     ]
     if missing_fields:
         raise TypeError(f"{missing_fields} are required.")
+    try:
+        uid_max_length = record.__class__._meta.get_field(
+            "uid"
+        ).max_length  # triggers FieldDoesNotExist
+        if len(kwargs["uid"]) != uid_max_length:  # triggers KeyError
+            raise ValidationError(
+                f'`uid` must be exactly {uid_max_length} characters long, got {len(kwargs["uid"])}.'
+            )
+    except (FieldDoesNotExist, KeyError):
+        pass
 
 
 def suggest_records_with_similar_names(record: Record, name_field: str, kwargs) -> bool:

tests/core/notebooks/with-title-initialized-consecutive-finish.ipynb

@@ -13,7 +13,19 @@
    "metadata": {},
    "outputs": [],
    "source": [
-    "import lamindb as ln"
+    "import lamindb as ln\n",
+    "import pytest\n",
+    "from lamindb.core.exceptions import ValidationError"
+   ]
+  },
+  {
+   "cell_type": "code",
+   "execution_count": null,
+   "metadata": {},
+   "outputs": [],
+   "source": [
+    "with pytest.raises(ValidationError):\n",
+    "    ln.track(\"ujPaFZ\")"
    ]
   },
   {
@@ -55,7 +67,7 @@
  ],
  "metadata": {
   "kernelspec": {
-   "display_name": "py39",
+   "display_name": "py310",
    "language": "python",
    "name": "python3"
   },