Cascade form groups on FormMapper::remove call

rccc · Jan 7, 2014 · 088967e · 088967e
1 parent 217a3f3
commit 088967e
Show file tree

Hide file tree

Showing 5 changed files with 70 additions and 0 deletions.
diff --git a/Admin/Admin.php b/Admin/Admin.php
@@ -1576,6 +1576,20 @@ public function setFormGroups(array $formGroups)
         $this->formGroups = $formGroups;
     }
 
+    /**
+     * {@inheritdoc}
+     */
+    public function removeFieldFromFormGroup($key)
+    {
+        foreach ($this->formGroups as $name => $formGroup) {
+            unset($this->formGroups[$name]['fields'][$key]);
+
+            if (empty($this->formGroups[$name]['fields'])) {
+                unset($this->formGroups[$name]);
+            }
+        }
+    }
+
     /**
      * @param array $group
      * @param array $keys

diff --git a/Admin/AdminInterface.php b/Admin/AdminInterface.php
@@ -823,6 +823,15 @@ public function getFormGroups();
      */
     public function setFormGroups(array $formGroups);
 
+    /**
+     * Remove a form group field
+     *
+     * @param $key
+     *
+     * @return void
+     */
+    public function removeFieldFromFormGroup($key);
+
     /**
      * Returns the show groups
      *
@@ -855,6 +864,15 @@ public function reorderShowGroup($group, array $keys);
      */
     public function addFormFieldDescription($name, FieldDescriptionInterface $fieldDescription);
 
+    /**
+     * Remove a FieldDescription
+     *
+     * @param string $name
+     *
+     * @return void
+     */
+    public function removeFormFieldDescription($name);
+
     /**
      * Returns true if this admin uses ACL
      *

diff --git a/Form/FormMapper.php b/Form/FormMapper.php
@@ -157,6 +157,7 @@ public function has($key)
     public function remove($key)
     {
         $this->admin->removeFormFieldDescription($key);
+        $this->admin->removeFieldFromFormGroup($key);
         $this->formBuilder->remove($key);
 
         return $this;

diff --git a/Tests/Admin/AdminTest.php b/Tests/Admin/AdminTest.php
@@ -1139,4 +1139,31 @@ private function createTagAdmin(Post $post)
 
         return $tagAdmin;
     }
+
+    public function testRemoveFieldFromFormGroup()
+    {
+        $formGroups = array(
+            'foobar' => array(
+                'fields' => array(
+                    'foo' => 'foo',
+                    'bar' => 'bar',
+                ),
+            )
+        );
+
+        $admin = new PostAdmin('sonata.post.admin.post', 'Application\Sonata\NewsBundle\Entity\Post', 'SonataNewsBundle:PostAdmin');
+        $admin->setFormGroups($formGroups);
+
+        $admin->removeFieldFromFormGroup('foo');
+        $this->assertEquals($admin->getFormGroups(), array(
+            'foobar' => array(
+                'fields' => array(
+                    'bar' => 'bar',
+                ),
+            )
+        ));
+
+        $admin->removeFieldFromFormGroup('bar');
+        $this->assertEquals($admin->getFormGroups(), array());
+    }
 }
diff --git a/Tests/Form/FormMapperTest.php b/Tests/Form/FormMapperTest.php
@@ -113,4 +113,14 @@ public function testWithFieldsCascadeTranslationDomain()
         ->add('foo', 'bar')
         ->end();
     }
+
+    public function testRemoveCascadeRemoveFieldFromFormGroup()
+    {
+        $this->admin->expects($this->once())
+            ->method('removeFieldFromFormGroup')
+            ->with('foo')
+        ;
+
+        $this->formMapper->remove('foo');
+    }
 }