Rkey len (bluesky-social#1066)

* set a lex limit on rkey length * enforce in repo package * rm checks in repo pkg * lift constraint on update
rcg4u · May 18, 2023 · cf36b36 · cf36b36
1 parent 37af595
commit cf36b36
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 3 deletions.
diff --git a/lexicons/com/atproto/repo/applyWrites.json b/lexicons/com/atproto/repo/applyWrites.json
@@ -42,7 +42,7 @@
       "required": ["action", "collection", "value"],
       "properties": {
         "collection": {"type": "string", "format": "nsid"},
-        "rkey": {"type": "string"},
+        "rkey": {"type": "string", "maxLength": 15},
         "value": {"type": "unknown"}
       }
     },

diff --git a/lexicons/com/atproto/repo/createRecord.json b/lexicons/com/atproto/repo/createRecord.json
@@ -23,7 +23,8 @@
             },
             "rkey": {
               "type": "string",
-              "description": "The key of the record."
+              "description": "The key of the record.",
+              "maxLength": 15
             },
             "validate": {
               "type": "boolean",

diff --git a/lexicons/com/atproto/repo/putRecord.json b/lexicons/com/atproto/repo/putRecord.json
@@ -24,7 +24,8 @@
             },
             "rkey": {
               "type": "string",
-              "description": "The key of the record."
+              "description": "The key of the record.",
+              "maxLength": 15
             },
             "validate": {
               "type": "boolean",

diff --git a/packages/api/src/client/lexicons.ts b/packages/api/src/client/lexicons.ts
@@ -1619,6 +1619,7 @@ export const schemaDict = {
           },
           rkey: {
             type: 'string',
+            maxLength: 15,
           },
           value: {
             type: 'unknown',
@@ -1684,6 +1685,7 @@ export const schemaDict = {
               rkey: {
                 type: 'string',
                 description: 'The key of the record.',
+                maxLength: 15,
               },
               validate: {
                 type: 'boolean',
@@ -2005,6 +2007,7 @@ export const schemaDict = {
               rkey: {
                 type: 'string',
                 description: 'The key of the record.',
+                maxLength: 15,
               },
               validate: {
                 type: 'boolean',

diff --git a/packages/pds/src/lexicon/lexicons.ts b/packages/pds/src/lexicon/lexicons.ts
@@ -1619,6 +1619,7 @@ export const schemaDict = {
           },
           rkey: {
             type: 'string',
+            maxLength: 15,
           },
           value: {
             type: 'unknown',
@@ -1684,6 +1685,7 @@ export const schemaDict = {
               rkey: {
                 type: 'string',
                 description: 'The key of the record.',
+                maxLength: 15,
               },
               validate: {
                 type: 'boolean',
@@ -2005,6 +2007,7 @@ export const schemaDict = {
               rkey: {
                 type: 'string',
                 description: 'The key of the record.',
+                maxLength: 15,
               },
               validate: {
                 type: 'boolean',