Remove fixed server type check in kerberos client (apache#4758)

## Motivation Currently, In Pulsar Kerberos authentication, The server type part of pulsar node principle is hard coded as "broker" and "proxy". The expected principle for pulsar nodes would be like "broker/[email protected]" or "proxy/[email protected]". But some times, user may want to re-use existing principle like "u-service/[email protected]", to test and play around, then "u-service" will not match service type of "broker" or "proxy", and the authentication will be rejected. This change is to remove the check of "broker" or "proxy" service type check. ## Modifaction Remove the check of "broker" or "proxy" service type check.
readinglab2 · Jul 19, 2019 · f5b20cd · f5b20cd
1 parent bbac857
commit f5b20cd
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/...r-client-auth-sasl/src/main/java/org/apache/pulsar/client/impl/auth/PulsarSaslClient.java b/...r-client-auth-sasl/src/main/java/org/apache/pulsar/client/impl/auth/PulsarSaslClient.java
@@ -52,9 +52,10 @@ public class PulsarSaslClient {
     public PulsarSaslClient(String serverHostname, String serverType, Subject subject) throws SaslException {
         checkArgument(subject != null, "Cannot create SASL client with NULL JAAS subject");
         checkArgument(!Strings.isNullOrEmpty(serverHostname), "Cannot create SASL client with NUll server name");
-        checkArgument(serverType.equalsIgnoreCase(SaslConstants.SASL_BROKER_PROTOCOL) ||
-                serverType.equalsIgnoreCase(SaslConstants.SASL_PROXY_PROTOCOL),
-            "Server type [" + serverType + "] invalid, should be broker or proxy");
+        if (!serverType.equals(SaslConstants.SASL_BROKER_PROTOCOL) && !serverType
+                                                                           .equals(SaslConstants.SASL_PROXY_PROTOCOL)) {
+            log.warn("The server type {} is not recommended", serverType);
+        }
 
         String serverPrincipal = serverType.toLowerCase() + "/" + serverHostname;
         this.clientSubject = subject;