Fix KhronosGroup#1484 Vertex group

realkotob · Nov 5, 2021 · e618dc7 · e618dc7
1 parent 9373d43
commit e618dc7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 8 deletions.
diff --git a/addons/io_scene_gltf2/blender/imp/gltf2_blender_mesh.py b/addons/io_scene_gltf2/blender/imp/gltf2_blender_mesh.py
@@ -303,9 +303,9 @@ def do_primitives(gltf, mesh_idx, skin_idx, mesh, ob):
     # TODO: this is slow :/
     if num_joint_sets:
         pyskin = gltf.data.skins[skin_idx]
-        for i, _ in enumerate(pyskin.joints):
-            # ob is a temp object, so don't worry about the name.
-            ob.vertex_groups.new(name='X%d' % i)
+        for i, node_idx in enumerate(pyskin.joints):
+            bone = gltf.vnodes[node_idx]
+            ob.vertex_groups.new(name=bone.blender_bone_name)
 
         vgs = list(ob.vertex_groups)
 

diff --git a/addons/io_scene_gltf2/blender/imp/gltf2_blender_node.py b/addons/io_scene_gltf2/blender/imp/gltf2_blender_node.py
@@ -241,11 +241,6 @@ def setup_skinning(gltf, pynode, obj):
 
         # Armature/bones should have already been created.
 
-        # Create vertex groups for each joint
-        for node_idx in pyskin.joints:
-            bone = gltf.vnodes[node_idx]
-            obj.vertex_groups.new(name=bone.blender_bone_name)
-
         # Create an Armature modifier
         first_bone = gltf.vnodes[pyskin.joints[0]]
         arma = gltf.vnodes[first_bone.bone_arma]