Fix issues that were causing async action creators to fail

rebecca-draben · Apr 23, 2016 · 929b8d8 · 929b8d8
1 parent 03d3d95
commit 929b8d8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/app/redux/actions/async.js b/app/redux/actions/async.js
@@ -239,7 +239,6 @@ export function setupDataStorage(api, patient) {
     dispatch(sync.setupDataStorageRequest());
 
     api.patient.post(patient, (err, createdPatient) => {
-      err = { status: 400, message: 'Messed up!' };
       if (err) {
         dispatch(sync.setupDataStorageFailure(
           createActionError(ErrorMessages.ERR_DSA_SETUP, err), err

diff --git a/test/unit/redux/actions/async.test.js b/test/unit/redux/actions/async.test.js
@@ -144,7 +144,7 @@ describe('Actions', () => {
 
         let expectedActions = [
           { type: 'CONFIRM_SIGNUP_REQUEST' },
-          { type: 'CONFIRM_SIGNUP_FAILURE', error: err, meta: { apiError: {status: 500, body: 'Error!'} } }
+          { type: 'CONFIRM_SIGNUP_FAILURE', error: err, payload: { signupKey: 'fakeSignupKey' }, meta: { apiError: {status: 500, body: 'Error!'} } }
         ];
         _.each(expectedActions, (action) => {
           expect(isTSA(action)).to.be.true;
@@ -172,8 +172,8 @@ describe('Actions', () => {
 
         let expectedActions = [
           { type: 'CONFIRM_SIGNUP_REQUEST' },
-          { type: 'CONFIRM_SIGNUP_FAILURE', error: err, meta: { apiError: {status: 400, message: 'User does not have a password'} } },
-          { type: '@@router/TRANSITION', payload: { args: [ '/verification-with-password' ], method: 'push' } }
+          { type: 'CONFIRM_SIGNUP_FAILURE', error: err, payload: { signupKey: 'fakeSignupKey' }, meta: { apiError: {status: 400, message: 'User does not have a password'} } },
+          { type: '@@router/TRANSITION', payload: { args: [ '/verification-with-password?signupKey=fakeSignupKey' ], method: 'push' } }
         ];
         _.each(expectedActions, (action) => {
           expect(isTSA(action)).to.be.true;