http2: fix reinjection check

We reinject when the sockets has already waiting data, remarked by @mildsunrise Co-authored-by: Alba Mendez <[email protected]> PR-URL: nodejs#35678 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Alba Mendez <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Ricky Zhou <[email protected]>
red1033 · Oct 25, 2020 · 1f703e1 · 1f703e1
1 parent 75202d9
commit 1f703e1
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/lib/internal/http2/core.js b/lib/internal/http2/core.js
@@ -3144,7 +3144,7 @@ function connect(authority, options, listener) {
   debug('Http2Session connect', options.createConnection);
   // Socket already has some buffered data - emulate receiving it
   // https://github.com/nodejs/node/issues/35475
-  if (typeof options.createConnection === 'function') {
+  if (socket && socket.readableLength) {
     let buf;
     while ((buf = socket.read()) !== null) {
       debug(`Http2Session connect: injecting ${buf.length} already in buffer`);