http2: refactor to use primordials instead of <string>.indexOf

PR-URL: nodejs#36679 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Pooja D P <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
red1033 · Jan 9, 2021 · 3af175f · 3af175f
1 parent e68299a
commit 3af175f
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/lib/internal/http2/compat.js b/lib/internal/http2/compat.js
@@ -11,6 +11,7 @@ const {
   ObjectPrototypeHasOwnProperty,
   ReflectApply,
   ReflectGetPrototypeOf,
+  StringPrototypeIncludes,
   StringPrototypeToLowerCase,
   StringPrototypeTrim,
   Symbol,
@@ -81,7 +82,9 @@ let statusConnectionHeaderWarned = false;
 // close as possible to the current require('http') API
 
 const assertValidHeader = hideStackFrames((name, value) => {
-  if (name === '' || typeof name !== 'string' || name.indexOf(' ') >= 0) {
+  if (name === '' ||
+      typeof name !== 'string' ||
+      StringPrototypeIncludes(name, ' ')) {
     throw new ERR_INVALID_HTTP_TOKEN('Header name', name);
   }
   if (isPseudoHeader(name)) {