Skip to content

Commit

Permalink
inspector, test: verify reported console message
Browse files Browse the repository at this point in the history
Many Inspector protocol clients rely on the top frame reported for the
console messages. This test makes sure correct location is reported.

PR-URL: nodejs#25455
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
  • Loading branch information
eugeneo authored and joyeecheung committed Jan 16, 2019
1 parent b367ab2 commit c7ec5e4
Showing 1 changed file with 31 additions and 0 deletions.
31 changes: 31 additions & 0 deletions test/parallel/test-inspector-console-top-frame.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
'use strict';

// Verify that the line containing console.log is reported as a top stack frame
// of the consoleAPICalled notification.
// Changing this will break many Inspector protocol clients, including
// debuggers that use that value for navigating from console messages to code.

const common = require('../common');
common.skipIfInspectorDisabled();

const assert = require('assert');
const { Session } = require('inspector');
const { basename } = require('path');

function logMessage() {
console.log('Log a message');
}

const session = new Session();
let topFrame;
session.once('Runtime.consoleAPICalled', (notification) => {
topFrame = (notification.params.stackTrace.callFrames[0]);
});
session.connect();
session.post('Runtime.enable');

logMessage(); // Triggers Inspector notification

session.disconnect();
assert.strictEqual(basename(topFrame.url), basename(__filename));
assert.strictEqual(topFrame.lineNumber, 15);

0 comments on commit c7ec5e4

Please sign in to comment.