Skip to content

Commit

Permalink
Merge conflicts resolved
Browse files Browse the repository at this point in the history
  • Loading branch information
manojVivek committed Jul 26, 2020
2 parents e326b84 + 1b9e6bf commit 1df60d5
Show file tree
Hide file tree
Showing 6 changed files with 31 additions and 3 deletions.
9 changes: 9 additions & 0 deletions .all-contributorsrc
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,15 @@
"contributions": [
"code"
]
},
{
"login": "rossmoody",
"name": "Ross Moody",
"avatar_url": "https://avatars0.githubusercontent.com/u/29072694?v=4",
"profile": "http://rossmoody.com",
"contributions": [
"design"
]
}
],
"contributorsPerLine": 5,
Expand Down
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Responsively App [![Twitter Follow](https://img.shields.io/twitter/follow/ResponsivelyApp?style=social)](https://twitter.com/ResponsivelyApp)
<!-- ALL-CONTRIBUTORS-BADGE:START - Do not remove or modify this section -->
[![All Contributors](https://img.shields.io/badge/all_contributors-26-orange.svg?style=flat-square)](#contributors-)
[![All Contributors](https://img.shields.io/badge/all_contributors-27-orange.svg?style=flat-square)](#contributors-)
<!-- ALL-CONTRIBUTORS-BADGE:END -->
[![Gitter chat](https://img.shields.io/gitter/room/badges/shields.svg)](https://gitter.im/responsively-app) [![xscode](https://img.shields.io/badge/Available%20on-xs%3Acode-blue?style=?style=plastic&logo=appveyor&logo=data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAEAAAABACAMAAACdt4HsAAAAGXRFWHRTb2Z0d2FyZQBBZG9iZSBJbWFnZVJlYWR5ccllPAAAAAZQTFRF////////VXz1bAAAAAJ0Uk5T/wDltzBKAAAAlUlEQVR42uzXSwqAMAwE0Mn9L+3Ggtgkk35QwcnSJo9S+yGwM9DCooCbgn4YrJ4CIPUcQF7/XSBbx2TEz4sAZ2q1RAECBAiYBlCtvwN+KiYAlG7UDGj59MViT9hOwEqAhYCtAsUZvL6I6W8c2wcbd+LIWSCHSTeSAAECngN4xxIDSK9f4B9t377Wd7H5Nt7/Xz8eAgwAvesLRjYYPuUAAAAASUVORK5CYII=)](https://xscode.com/manojvivek/responsively-app) [![PRs Welcome](https://img.shields.io/badge/PRs-welcome-brightgreen.svg?style=flat-square)](https://github.com/manojVivek/responsively-app/issues)

Expand Down Expand Up @@ -103,6 +103,7 @@ Thanks go to these wonderful people ([emoji key](https://allcontributors.org/doc
</tr>
<tr>
<td align="center"><a href="https://github.com/jzabala"><img src="https://avatars0.githubusercontent.com/u/1315054?v=4" width="100px;" alt=""/><br /><sub><b>Johnny Zabala</b></sub></a><br /><a href="https://github.com/manojVivek/responsively-app/commits?author=jzabala" title="Code">💻</a></td>
<td align="center"><a href="http://rossmoody.com"><img src="https://avatars0.githubusercontent.com/u/29072694?v=4" width="100px;" alt=""/><br /><sub><b>Ross Moody</b></sub></a><br /><a href="#design-rossmoody" title="Design">🎨</a></td>
</tr>
</table>

Expand Down
11 changes: 11 additions & 0 deletions desktop-app/app/components/WebView/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,7 @@ class WebView extends Component {
this.dbg.attach();
this.dbg.on('message', this._onDebuggerEvent);
}
if (this.isMobile) this.hideScrollbar();
});

if (this.props.transmitNavigatorStatus) {
Expand Down Expand Up @@ -490,6 +491,16 @@ class WebView extends Component {
`);
};

hideScrollbar = () => {
this.webviewRef.current.insertCSS(
`
body::-webkit-scrollbar {
display: none;
}
`
);
};

_isDevToolsOpen = () =>
!!this.props.browser.devToolsConfig.activeDevTools.find(
({deviceId}) => deviceId === this.props.device.id
Expand Down
2 changes: 2 additions & 0 deletions desktop-app/app/main.dev.js
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ import {
initBrowserSync,
getBrowserSyncHost,
getBrowserSyncEmbedScriptURL,
closeBrowserSync,
} from './utils/browserSync';
import {getHostFromURL} from './utils/urlUtils';
import browserSync from 'browser-sync';
Expand Down Expand Up @@ -117,6 +118,7 @@ app.on('window-all-closed', () => {
ipcMain.removeHandler('get-local-extension-path');
ipcMain.removeHandler('get-screen-shot-save-path');
ipcMain.removeHandler('request-browser-sync');
closeBrowserSync();
// Respect the OSX convention of having the application in memory even
// after all windows have been closed
if (process.platform !== 'darwin') {
Expand Down
5 changes: 5 additions & 0 deletions desktop-app/app/utils/browserSync.js
Original file line number Diff line number Diff line change
Expand Up @@ -35,3 +35,8 @@ async function initInstance(): Promise<> {
);
});
}

export function closeBrowserSync() {
browserSync.cleanup();
browserSync.exit();
}
4 changes: 2 additions & 2 deletions website/pages/assets/appMessages.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"statusBarMessage": {
"text": "Support us on Twitter, we just crossed 1,000 followers! 🔥",
"link": "https://twitter.com/ResponsivelyApp"
"text": "We need your thoughts, please pitch in! Just 2 mins 🙏",
"link": "https://docs.google.com/forms/d/e/1FAIpQLSdjwMkFD5ftq6mGqQKUn6ITh175uTkxoQ2LXsTshnBN6rVavw/viewform?usp=sf_link"
}
}

0 comments on commit 1df60d5

Please sign in to comment.