Fix a couple of bugs uncovered by the Clang static analyzer #215
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran the Clang static analyzer on a project I'm working on that uses hiredis and it found a couple of bugs.
There were three warnings, of which two are definitely legit. I have fixed these in the commits below.
The one warning I wasn't sure about was this one:
This is in redisProcessCallbacks and it looks like it's triggerable when
redisGetReply
returnsREDIS_OK
but doesn't setreply
to anything. I'm not familiar enough with the code to determine if this is possible though.