Skip to content

Commit

Permalink
wimax: fix kconfig interactions with rfkill and input layers
Browse files Browse the repository at this point in the history
WiMAX can work without RFKILL, but it was missing a check to make sure
RFKILL is not being made a module with wimax compiled into the
kernel. This caused failed builds in s390, where CONFIG_INPUT is
always off.

When RFKILL is enabled, the code uses the input layer to report
hardware switch changes; thus, if RFKILL is enabled, INPUT has to be
too. It also needs to display some message when INPUT is disabled that
explains why WiMAX is not selectable.

(issues found by Randy Dunlap in the linux-next tree).

Signed-off-by: Inaky Perez-Gonzalez <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
Inaky Perez-Gonzalez authored and davem330 committed Jan 8, 2009
1 parent d48e470 commit 71f78af
Showing 1 changed file with 14 additions and 0 deletions.
14 changes: 14 additions & 0 deletions net/wimax/Kconfig
Original file line number Diff line number Diff line change
@@ -1,9 +1,23 @@
#
# WiMAX LAN device configuration
#
# Note the ugly 'depends on' on WIMAX: that disallows RFKILL to be a
# module if WIMAX is to be linked in. The WiMAX code is done in such a
# way that it doesn't require and explicit dependency on RFKILL in
# case an embedded system wants to rip it out.
#
# As well, enablement of the RFKILL code means we need the INPUT layer
# support to inject events coming from hw rfkill switches. That
# dependency could be killed if input.h provided appropiate means to
# work when input is disabled.

comment "WiMAX Wireless Broadband support requires CONFIG_INPUT enabled"
depends on INPUT = n && RFKILL != n

menuconfig WIMAX
tristate "WiMAX Wireless Broadband support"
depends on (y && RFKILL != m) || m
depends on (INPUT && RFKILL != n) || RFKILL = n
help

Select to configure support for devices that provide
Expand Down

0 comments on commit 71f78af

Please sign in to comment.