Skip to content

Commit

Permalink
parisc: trivial fixes
Browse files Browse the repository at this point in the history
trivial fixes:
- use KERN_WARNING for printk()
- use BUG_ON() instead of "if (xx) BUG();"

Signed-off-by: Helge Deller <[email protected]>
Signed-off-by: Kyle McMartin <[email protected]>

--
To unsubscribe from this list: send the line "unsubscribe linux-parisc" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
  • Loading branch information
hdeller authored and jkkm committed Jan 5, 2009
1 parent 70da2d9 commit 7f2347a
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 7 deletions.
2 changes: 1 addition & 1 deletion arch/parisc/kernel/irq.c
Original file line number Diff line number Diff line change
Expand Up @@ -421,5 +421,5 @@ void __init init_IRQ(void)

void ack_bad_irq(unsigned int irq)
{
printk("unexpected IRQ %d\n", irq);
printk(KERN_WARNING "unexpected IRQ %d\n", irq);
}
8 changes: 2 additions & 6 deletions arch/parisc/kernel/smp.c
Original file line number Diff line number Diff line change
Expand Up @@ -224,10 +224,7 @@ send_IPI_mask(cpumask_t mask, enum ipi_message_type op)
static inline void
send_IPI_single(int dest_cpu, enum ipi_message_type op)
{
if (dest_cpu == NO_PROC_ID) {
BUG();
return;
}
BUG_ON(dest_cpu == NO_PROC_ID);

ipi_send(dest_cpu, op);
}
Expand Down Expand Up @@ -309,8 +306,7 @@ smp_cpu_init(int cpunum)
/* Initialise the idle task for this CPU */
atomic_inc(&init_mm.mm_count);
current->active_mm = &init_mm;
if(current->mm)
BUG();
BUG_ON(current->mm);
enter_lazy_tlb(&init_mm, current);

init_IRQ(); /* make sure no IRQs are enabled or pending */
Expand Down

0 comments on commit 7f2347a

Please sign in to comment.