Skip to content

Commit

Permalink
block: don't use plugging on SSD devices
Browse files Browse the repository at this point in the history
We just want to hand the first bits of IO to the device as fast
as possible. Gains a few percent on the IOPS rate.

Signed-off-by: Jens Axboe <[email protected]>
  • Loading branch information
Jens Axboe committed Dec 29, 2008
1 parent a185eb4 commit a31a973
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions block/blk-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -268,8 +268,7 @@ void __generic_unplug_device(struct request_queue *q)
{
if (unlikely(blk_queue_stopped(q)))
return;

if (!blk_remove_plug(q))
if (!blk_remove_plug(q) && !blk_queue_nonrot(q))
return;

q->request_fn(q);
Expand Down Expand Up @@ -1241,11 +1240,11 @@ static int __make_request(struct request_queue *q, struct bio *bio)
if (test_bit(QUEUE_FLAG_SAME_COMP, &q->queue_flags) ||
bio_flagged(bio, BIO_CPU_AFFINE))
req->cpu = blk_cpu_to_group(smp_processor_id());
if (elv_queue_empty(q))
if (!blk_queue_nonrot(q) && elv_queue_empty(q))
blk_plug_device(q);
add_request(q, req);
out:
if (sync)
if (sync || blk_queue_nonrot(q))
__generic_unplug_device(q);
spin_unlock_irq(q->queue_lock);
return 0;
Expand Down

0 comments on commit a31a973

Please sign in to comment.