ext4: check ext4_journal_get_write_access() errors

Check ext4_journal_get_write_access() errors. Signed-off-by: Akinobu Mita <[email protected]> Signed-off-by: "Theodore Ts'o" <[email protected]> Cc: Stephen Tweedie <[email protected]> Cc: [email protected] Cc: Andrew Morton <[email protected]> Cc: Mingming Cao <[email protected]>
redpig · Apr 17, 2008 · a871611 · a871611
1 parent c0a4ef3
commit a871611
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
@@ -57,10 +57,15 @@ static struct buffer_head *ext4_append(handle_t *handle,
 
 	*block = inode->i_size >> inode->i_sb->s_blocksize_bits;
 
-	if ((bh = ext4_bread(handle, inode, *block, 1, err))) {
+	bh = ext4_bread(handle, inode, *block, 1, err);
+	if (bh) {
 		inode->i_size += inode->i_sb->s_blocksize;
 		EXT4_I(inode)->i_disksize = inode->i_size;
-		ext4_journal_get_write_access(handle,bh);
+		*err = ext4_journal_get_write_access(handle, bh);
+		if (*err) {
+			brelse(bh);
+			bh = NULL;
+		}
 	}
 	return bh;
 }